Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all 3-d restart variables are being remapped #203

Closed
Hallberg-NOAA opened this issue Sep 7, 2022 · 1 comment
Closed

Not all 3-d restart variables are being remapped #203

Hallberg-NOAA opened this issue Sep 7, 2022 · 1 comment

Comments

@Hallberg-NOAA
Copy link
Member

The restart files include all of the variables that are required to give a bitwise identical restart between run segments. Because these restarts are typically written immediately after the model has been remapped, they should also give a reliable indicator of all of the 3-d variables that need to be remapped.

An examination of the code shows that while the basic state variables (layer thickness, velocities and tracers) are being remapped, there are a number of other 3-d variables that are not being remapped, but probably should be. These can be grouped into several categories:

  • Layer mass transports, time-step averaged thicknesses, time-step averaged velocities, and horizontal viscosity accelerations that are used in the predictor step momentum equation with the split_RK2 time stepping scheme. The first three variables are combined to give estimates of the Coriolis and momentum self-advection accelerations, so perhaps these estimated accelerations should be remapped, and not the fields themselves.
  • Shear-driven viscosities, as stored in visc%Kv_shear and visc%Kv_shear_Bu. These are defined at interfaces, not as layer averages, and they are not necessarily conserved quantities, so they will probably not be remapped using the same expressions as for other variables.
  • Open boundary condition radiation terms and tracer reservoirs.
  • Previous 3-dimesional Stokes drift velocities with active wave coupling. (This one only seems to be used in a diagnostic, but it may also be a part of the incomplete development of a new capabiltiy.)
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Oct 8, 2022
Merged
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 1, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
c8fae41 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 7, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
1a24dae 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Nov 7, 2022
Merged
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 9, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
47557b2 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 16, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
b108529 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 16, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
71ab090 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 18, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
987a0ef 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 21, 2022
@Hallberg-NOAA
+Add REMAP_AUXILIARY_VARS to remap accelerations
ba389e0 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com/NOAA-GFDL/issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
marshallward pushed a commit that referenced this issue Nov 22, 2022
@Hallberg-NOAA @marshallward
+Add REMAP_AUXILIARY_VARS to remap accelerations
aa44c32 
  Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that
are used in the predictor step of the split RK2 time stepping scheme.  Also
added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and
remap_vertvisc_aux_vars to do the remapping, and code to call these routines
when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false,
and all answers are bitwise identical, but the entire MOM6-examples regression
suite has been run with this set to true, and they do appear to give physically
plausible answers in all cases, partially addressing the issue noted at
github.com//issues/203.  New entries are added to the
MOM_parameter_doc files, and there are three new publicly visible routines, but
by default answers do not change.
@Hallberg-NOAA
Copy link
Member Author

As a result of PR #233 being merged in, this issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Hallberg-NOAA