Addressing GNU Warnings #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lharris4
reviewed
Oct 6, 2021
| @@ -800,7 +800,8 @@ subroutine ps_nudging(dt, factor, factor_nwp, npz, ak, bk, ps_obs, mask, tm, ps, | |||
| pt0 = tm(i,j)/(pk0(km+1)-pk0(km))*(kappa*(pn0(km+1)-pn0(km))) | |||
| pst = pk0(km+1) + (gz0(i,j)-phis(i,j))/(cp_air*pt0) | |||
| endif | |||
| 666 ps_dt(i,j) = pst**(1./kappa) - ps(i,j) | |||
| ps_dt(i,j) = pst**(1./kappa) - ps(i,j) | |||
There was a problem hiding this comment.
In the original code, 'goto 666' will execute the ps_dt(i,j) assignment. The revised code will not.
|
Other than the one goto statement in fv_nudge I think this is fine. |
|
handled a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are fixes to the GCC 10.2.0 warnings
I have also added a change to fv_regional_bc so that the flag "-fallow-invalid-boz" is no longer needed for GNU compilation.
Fixes #78
How Has This Been Tested?
Changes were tested with SHiELD model RTS tests
Checklist:
Please check all whether they apply or not