Fortran 2018 standard issues

[thomas-robinson]

While compiling with the gfortran 10.2.0 compiler, I encountered this set of warnings

/home/Thomas.Robinson/AM4/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_nudge.F90:804:44:

  804 | 666   ps_dt(i,j) = pst**(1./kappa) - ps(i,j)
      |                                            1
Warning: Fortran 2018 deleted feature: DO termination statement which is not END DO or CONTINUE with label 666 at (1)
/home/Thomas.Robinson/AM4/AM4/src/GFDL_atmos_cubed_sphere/GFDL_tools/fv_ada_nudge.F90:1037:44:

 1037 | 666   ps_dt(i,j) = pst**(1./kappa) - ps(i,j)
      |                                            1
Warning: Fortran 2018 deleted feature: DO termination statement which is not END DO or CONTINUE with label 666 at (1)

/root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5055:19:

 5055 |       do 500 i=1,im
      |                   1
Warning: Fortran 2018 deleted feature: Shared DO termination label 500 at (1)
/root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5056:39:

 5056 | 500   a6(i,k) = delp(i,k-1) + delp(i,k)
      |                                       1
Warning: Fortran 2018 deleted feature: DO termination statement which is not END DO or CONTINUE with label 500 at (1)
/root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5059:20:

 5059 |       do 1000 i=1,im
      |                    1
Warning: Fortran 2018 deleted feature: Shared DO termination label 1000 at (1)
/root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5064:20:

 5064 |       do 1220 i=1,im
      |                    1
Warning: Fortran 2018 deleted feature: Shared DO termination label 1220 at (1)

[lharris4]

Hi, Tom. This is in a number of highly-optimized sections of the code, which also has gotos that could be replaced with labels and continue/break statements. Would you like to replace these with more modern statements, and then test for bit-repro? Thanks, Lucas

…

On Thu, Mar 18, 2021 at 9:49 AM Tom Robinson ***@***.***> wrote: While compiling with the gfortran 10.2.0 compiler, I encountered this set of warnings /root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5055:19: 5055 | do 500 i=1,im | 1 Warning: Fortran 2018 deleted feature: Shared DO termination label 500 at (1) /root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5056:39: 5056 | 500 a6(i,k) = delp(i,k-1) + delp(i,k) | 1 Warning: Fortran 2018 deleted feature: DO termination statement which is not END DO or CONTINUE with label 500 at (1) /root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5059:20: 5059 | do 1000 i=1,im | 1 Warning: Fortran 2018 deleted feature: Shared DO termination label 1000 at (1) /root/AM4/src/GFDL_atmos_cubed_sphere/tools/fv_diagnostics.F90:5064:20: 5064 | do 1220 i=1,im | 1 Warning: Fortran 2018 deleted feature: Shared DO termination label 1220 at (1) This was the set of warnings I noticed. There may be more. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#78>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVFZCKRRA26JZVVYMH3TEIAIDANCNFSM4ZMVEENQ> .

[climbfuji]

Thanks Lucas, I appreciate that you are looking at this. I have seen these compiler warnings and wanted to fix them for quite a while.

[bensonr]

@thomas-robinson please work with @laurenchilutti to systematically work through these F18 issues.

[thomas-robinson]

I updated the original issue with a "complete" list of Fortran 2018 warnings.

[thomas-robinson]

@laurenchilutti @bensonr Where do you suggest I start from? master? dev/gfdl?

[lharris4]

I think you should start from our fv3team/main GitLab and then we can push it out to the public GitHub. Thanks, Lucas

…

On Thu, Mar 18, 2021 at 11:25 AM Tom Robinson ***@***.***> wrote: @laurenchilutti <https://github.com/laurenchilutti> @bensonr <https://github.com/bensonr> Where do you suggest I start from? master? dev/gfdl? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#78 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVCWIIQNFU3TCEYYRRLTEILNVANCNFSM4ZMVEENQ> .

[bensonr]

After conversations with @thomas-robinson and @lharris4, the changes will be implemented in the private gitlab fork within the GFDL hierarchy. The changes once vetted will be brought into NOAA-GFDL::master and pushed to dev/emc. At this point we'll also synchronize things with dev/gfdl.

[laurenchilutti]

A merge request has been submitted on Gitlab.

[bensonr]

need to merge master -> dev/gfdl

[laurenchilutti]

Issue addressed via merge of minor updates from GFDL Weather and Climate Dynamics Division on October 6 2021 (commit 94e9f2c)