Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prepobs/v1.1.0 #2840

Closed
KateFriedman-NOAA opened this issue Aug 16, 2024 · 2 comments · Fixed by #2903
Closed

Update to prepobs/v1.1.0 #2840

KateFriedman-NOAA opened this issue Aug 16, 2024 · 2 comments · Fixed by #2903
Assignees
Labels
feature New feature or request

Comments

@KateFriedman-NOAA
Copy link
Member

What new functionality do you need?

Need develop to run with the new prepobs/1.1.0 version that was implemented into operations this past May.

Will need to update prepobs in conjunction with new obsproc version (issue #2291).

Operations issue #2837 will be taken care of first due to urgency.

What are the requirements for the new functionality?

That the prepbufr file is produced without error.

Acceptance Criteria

Invoking the prepobs/1.1.0 module works and the prepbufr file is generated successfully while also using the newer obsproc/v1.2.

Suggest a solution (optional)

No response

@KateFriedman-NOAA KateFriedman-NOAA added the feature New feature or request label Aug 16, 2024
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Aug 16, 2024
KateFriedman-NOAA added a commit that referenced this issue Aug 21, 2024
- Update prepobs_run_ver to "1.1.0" in version files
- Only used in developer runs, does not impact ops

Refs #2840
KateFriedman-NOAA added a commit that referenced this issue Aug 21, 2024
Update the prepobs package version to `1.1.0` via the `prepobs_run_ver` variable in the version files.
This update was missed in the prior PR to update to `obsproc/v1.2` in GFSv16.3.16 but only affected
developer runs; operations is fine as it correctly gets prepobs/v1.1.0 through obsproc.

Resolves #2837
Refs #2840
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Aug 26, 2024
- Update to obsproc/v1.2.0 and prepobs/v1.1.0
- Revert back to glopara installs on Orion/Hercules
- Remove default version for obsproc in config.base

Refs NOAA-EMC#2291
Refs NOAA-EMC#2840
Refs NOAA-EMC#2841
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Aug 26, 2024
Change Orion BASE_GIT to the same as Hercules (git_rocky9).

Refs NOAA-EMC#2291
Refs NOAA-EMC#2840
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 10, 2024
Update module_base.gaea.lua to use the prepobs_run_ver
instead of a hardcoded version.

Refs NOAA-EMC#2840
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 10, 2024
Install of prepobs/v1.1.0 on WCOSS2 was installed under
the folder name "1.1.0_gfsv17" to keep the v16 package
from using it and to differentiate it from the ops version.

Refs NOAA-EMC#2840
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 11, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 11, 2024
This helps GFSv16 users avoid using this install
instead of the operational module version.

Refs NOAA-EMC#2840
@KateFriedman-NOAA
Copy link
Member Author

@WalterKolczynski-NOAA Please install prepobs/v1.1.0 on MSU, thanks!

git clone -b prepobs.v1.1.0-rd-gfsv17 https://github.com/NOAA-EMC/prepobs.git ./v1.1.0
cd v1.1.0
INSTALL_TARGET=orion[hercules] INSTALL_PREFIX=PATH_TO_v1.1.0_INSTALL ./ush/build.sh

@WalterKolczynski-NOAA
Copy link
Contributor

Installed on MSU

KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 17, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 17, 2024
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this issue Sep 19, 2024
This PR updates the `develop` branch to use the newer operational
`obsproc/v1.2.0` and `prepobs/v1.1.0`. The obsproc/prepobs installs in
glopara space on supported platforms use tags cut from the `dev/gfsv17`
branches in the respective repos. The installation of `prepobs/v1.1.0`
on WCOSS2 is called "gfsv17_v1.1.0" to help avoid GFSv16 users using it
instead of the operational module.

Also, the `HOMEobsproc` path is updated to set an empty default for
`obsproc_run_ver`. This both removes the need to set a default (and
constantly update it, which is duplication) and avoid the unset variable
error when the fcst jobs use their own load module script that does not
know `obsproc_run_ver`:
```
export HOMEobsproc="${BASE_GIT:-}/obsproc/v${obsproc_run_ver:-}"
```

This PR also reverts the prepobs and fit2obs installs on MSU back to the
glopara space from the temporary `/work/noaa/global/kfriedma/glopara`
space installs.

Lastly, this PR also includes updates to complete issue NOAA-EMC#2844 (merge
`build.spack.ver` and `run.spack.ver`).

Resolves NOAA-EMC#2291
Resolves NOAA-EMC#2840
Resolves NOAA-EMC#2844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants