-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong version number for prepobs in operational workflow #2837
Comments
@ADCollard are you talking about this in
|
I think I see what @ADCollard is referencing, the
The GFS doesn't reference This seems to have slipped through a crack. My guess is our @ADCollard Can you confirm that the prepbufr file is reproduced when you run with |
Prepobs has been v1.1.0 since 22 May 2024. Before that it was 1.0.1Version v1.1.0 is needed for the uprair dumps obs to get into the prepbufr file ( they are ‘hiding’ into ADPUPA section of the prepbufr file) On Aug 15, 2024, at 9:42 PM, Kate Friedman ***@***.***> wrote:
I think I see what @ADCollard is referencing, the obsproc_gdas[gfs]_atmos_dump jobs in ops are using the newer prepobs/v1.1.0 package (via the module):
***@***.***:/lfs/h1/ops/prod/packages/gfs.v16.3.16> grep prepobs /lfs/h1/ops/prod/output/20240815/obsproc_gdas_atmos_dump_00.o175652603
+++ 1 + export prepobs_ver=1.1.0
+++ 1 + prepobs_ver=1.1.0
prepobs_ver=1.1.0
The GFS doesn't reference prepobs directly. The prepobs, especially now that it's a module, is effectively an upstream of the GFS upstream obsproc dependency. That version setting prepobs_run_ver in versions/wcoss2.ver is only used outside of ops during developer runs. The prepobs version is not set or referenced within the GFS otherwise.
This seems to have slipped through a crack. My guess is our prepobs_run_ver variable should have been updated to 1.1.0 when the GFS went to obsproc.v1.2 for GFSv16.3.15 in late May.
@ADCollard Can you confirm that the prepbufr file is reproduced when you run with prepobs_run_ver=1.1.0 in versions/wcoss2.ver?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***>
|
Thanks for confirming @ilianagenkova ! I'll work to update the prepobs version in our v16 branch for developer use and also update our |
@XuanliLi-NOAA ran a test case with prepobs v1.1.0 and was able to reproduce operations, confirming that this is the issue. |
Thanks @KateFriedman-NOAA and @ilianagenkova ! |
Excellent, thanks for confirming @XuanliLi-NOAA and @ADCollard ! |
Update the prepobs package version to `1.1.0` via the `prepobs_run_ver` variable in the version files. This update was missed in the prior PR to update to `obsproc/v1.2` in GFSv16.3.16 but only affected developer runs; operations is fine as it correctly gets prepobs/v1.1.0 through obsproc. Resolves #2837 Refs #2840
Released the updated |
What is wrong?
The current version of
prepobs
in operations is 1.1.0. In https://github.com/NOAA-EMC/global-workflow/blob/gfs.v16.3.16/versions/wcoss2.ver it is still 1.0.1.What should have happened?
Need correct version number
What machines are impacted?
All or N/A
Steps to reproduce
Operational prepbufr cannot be reproduced by the prep step in global-workflow
Additional information
Asking @ilianagenkova to confirm this is correct.
Do you have a proposed solution?
No response
The text was updated successfully, but these errors were encountered: