Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version number for prepobs in operational workflow #2837

Closed
ADCollard opened this issue Aug 15, 2024 · 8 comments · Fixed by #2849
Closed

Wrong version number for prepobs in operational workflow #2837

ADCollard opened this issue Aug 15, 2024 · 8 comments · Fixed by #2849
Assignees
Labels
bug Something isn't working

Comments

@ADCollard
Copy link
Contributor

What is wrong?

The current version of prepobs in operations is 1.1.0. In https://github.com/NOAA-EMC/global-workflow/blob/gfs.v16.3.16/versions/wcoss2.ver it is still 1.0.1.

What should have happened?

Need correct version number

What machines are impacted?

All or N/A

Steps to reproduce

Operational prepbufr cannot be reproduced by the prep step in global-workflow

Additional information

Asking @ilianagenkova to confirm this is correct.

Do you have a proposed solution?

No response

@ADCollard ADCollard added bug Something isn't working triage Issues that are triage labels Aug 15, 2024
@KateFriedman-NOAA KateFriedman-NOAA removed the triage Issues that are triage label Aug 15, 2024
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Aug 15, 2024
@KateFriedman-NOAA
Copy link
Member

@ADCollard are you talking about this in versions/wcoss2.ver?

export prepobs_run_ver=1.0.1

@KateFriedman-NOAA
Copy link
Member

I think I see what @ADCollard is referencing, the obsproc_gdas[gfs]_atmos_dump jobs in ops are using the newer prepobs/v1.1.0 package (via the module):

kate.friedman@clogin09:/lfs/h1/ops/prod/packages/gfs.v16.3.16> grep prepobs /lfs/h1/ops/prod/output/20240815/obsproc_gdas_atmos_dump_00.o175652603
+++ 1 + export prepobs_ver=1.1.0
+++ 1 + prepobs_ver=1.1.0
prepobs_ver=1.1.0

The GFS doesn't reference prepobs directly. The prepobs, especially now that it's a module, is effectively an upstream of the GFS upstream obsproc dependency. That version setting prepobs_run_ver in versions/wcoss2.ver is only used outside of ops during developer runs. The prepobs version is not set or referenced within the GFS otherwise.

This seems to have slipped through a crack. My guess is our prepobs_run_ver variable should have been updated to 1.1.0 when the GFS went to obsproc.v1.2 for GFSv16.3.15 in late May.

@ADCollard Can you confirm that the prepbufr file is reproduced when you run with prepobs_run_ver=1.1.0 in versions/wcoss2.ver?

@ilianagenkova
Copy link
Contributor

ilianagenkova commented Aug 16, 2024 via email

@KateFriedman-NOAA
Copy link
Member

Prepobs has been v1.1.0 since 22 May 2024. Before that it was 1.0.1Version v1.1.0 is needed for the uprair dumps obs to get into the prepbufr file ( they are ‘hiding’ into ADPUPA section of the prepbufr file)

Thanks for confirming @ilianagenkova ! I'll work to update the prepobs version in our v16 branch for developer use and also update our develop branch to use it for v17 testing.

@ADCollard
Copy link
Contributor Author

@XuanliLi-NOAA ran a test case with prepobs v1.1.0 and was able to reproduce operations, confirming that this is the issue.

@ADCollard
Copy link
Contributor Author

Prepobs has been v1.1.0 since 22 May 2024. Before that it was 1.0.1Version v1.1.0 is needed for the uprair dumps obs to get into the prepbufr file ( they are ‘hiding’ into ADPUPA section of the prepbufr file)

Thanks for confirming @ilianagenkova ! I'll work to update the prepobs version in our v16 branch for developer use and also update our develop branch to use it for v17 testing.

Thanks @KateFriedman-NOAA and @ilianagenkova !

@KateFriedman-NOAA
Copy link
Member

@XuanliLi-NOAA ran a test case with prepobs v1.1.0 and was able to reproduce operations, confirming that this is the issue.

Excellent, thanks for confirming @XuanliLi-NOAA and @ADCollard !

@KateFriedman-NOAA KateFriedman-NOAA linked a pull request Aug 21, 2024 that will close this issue
KateFriedman-NOAA added a commit that referenced this issue Aug 21, 2024
Update the prepobs package version to `1.1.0` via the `prepobs_run_ver` variable in the version files.
This update was missed in the prior PR to update to `obsproc/v1.2` in GFSv16.3.16 but only affected
developer runs; operations is fine as it correctly gets prepobs/v1.1.0 through obsproc.

Resolves #2837
Refs #2840
@KateFriedman-NOAA
Copy link
Member

Released the updated dev/gfs.v16 branch as GFSv16.3.16.1: https://github.com/NOAA-EMC/global-workflow/releases/tag/gfs.v16.3.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants