Post refactor p1 #196

WenMeng-NOAA · 2020-10-05T17:06:47Z

UPP refactor phase 1 merging:

Remove writing out GRIB1 option.
Improve legacy goto statements.

Refactor

Merge remote-tracking branch 'upstream/develop' into develop

CALWXT.f: modified, use “cycle” to replace “go to”, keep several “go to” CALWXT_RAMER.f: modified, use “cycle” and “exit” to replace “go to, keep several “go to”

BoCui-NOAA · 2020-10-13T20:28:48Z

AVIATION.f : reviewed, remove “go To”
CALHEL.f: reviewed , remove “go To”
CALLCL.f: reviewed , remove “go To”
CALMICT.f : modified, keep using “go to”
CALWXT.f: modified, use “cycle” and “do while” to replace “go to”
CALWXT_RAMER.f: modified, use “cycle” and “exit” to replace “go to, keep using several “go to”
CALWXT_REVISED.f: modified, use “cycle” and “do while” to replace “go to”
WETBULB.f : checked, use cycle to replace “goto”
WETFRZLVL.f: modified, use cycle and exit to replace “goto”
getIVariableN.f: checked, read data from WRF output, keep using “goto”
getVariable.f: checked, read data from WRF output, keep using “goto”

BoCui-NOAA · 2020-10-16T20:08:08Z

DEWPOINT.f: modified , use do while to replace “go to”
FGAMMA.f: unconditional GO TO statement, keep it or remove it?
FRZLVL.f: modified , use cycle to replace “go to”
LFMFLD.f: modified , use exit to replace “go to”
LFMFLD_GFS.f: modified , use exit to replace “go to”
MDL2AGL.f: reviewed , remove “go To”
MDL2P.f : modified, keep using “go to”

Merge remote-tracking branch 'upstream/develop' into post_refactor_p1

…nto post_refactor_p1

sorc/ncep_post.fd/CALHEL.f

WenMeng-NOAA · 2020-10-23T19:41:30Z

@BoCui-NOAA, @HuiyaChuang-NOAA In the CALHEL.f, I might think the "goto 30" is for jumping out the L loop not if statement.

The code tested with a RAPv5 case and can reproduce the results.

…C_post into post_refactor_p1

BoCui-NOAA · 2020-10-28T17:03:12Z

Wen,

I already modified the 3 codes, please take a review.

Bo

BoCui-NOAA · 2020-10-28T17:05:42Z

@hu5970 Will you think the replace of "GOTO 666" in SERVER.f could be:
!666 continue
do while (.not. DONE)
CALL MPI_RECV(...)
IF (DONE) THEN
PRINT *, 'SHUTTING DOWN IO SERVER ...'
!!RETURN ! RETURNING to MAIN
EXIT !RETURNING to MAIN
ENDIF
...
...
!
! OUT TO DISK WE GO ...
!
CALL WRYTE(LUN,COUNT,BUF)
DEALLOCATE(BUF)
!GTO 666 !remove goto
enddo !end do while loop

modified the code following Ming's comments.

fossell · 2020-10-28T19:06:09Z

@JesseMeng-NOAA and @fossell, I see "GRIBIT.o" is removed from makefile_module, will we consider delete file GRIBIT.F from source code directory?

I think we should remove the routine entirely since it will not be used.

JesseMeng-NOAA · 2020-10-29T12:12:10Z

Sounds good. Thanks Jesse

…

On Wednesday, October 28, 2020, Kate Fossell ***@***.***> wrote: @JesseMeng-NOAA <https://github.com/JesseMeng-NOAA> and @fossell <https://github.com/fossell>, I see "GRIBIT.o" is removed from makefile_module, will we consider delete file GRIBIT.F from source code directory? I think we should remove the routine entirely since it will not be used. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALXNRCOHUFSD5B6ZVA2XQ3DSNBTS7ANCNFSM4SE6K6MA> .

-- ============================================== Dr. Jesse Meng IMSG at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Room 2037 College Park, MD 20740 email: [email protected] ==============================================

WenMeng-NOAA · 2020-10-29T12:23:20Z

@fossell and @JesseMeng-NOAA Thanks for clarifying. I will remove this routine.

sorc/ncep_post.fd/WETFRZLVL.f

WenMeng-NOAA · 2020-11-05T16:52:27Z

The UPP regression tests were conducted on WCOSS Dell, Cray and Hera. No changed results were found. This PR is ready for merging.

…ach repository (NOAA-EMC#304) ## DESCRIPTION OF CHANGES: The new top-level cmake build for the SRW App ([SRW App PR#27](ufs-community/ufs-srweather-app#27)) results in some executables having different names. This PR makes modifications that 1. Allow the workflow to run successfully with the new cmake build and its different executable names, and 2. Allow back-compatibility with the old build system to allow for a gradual transition to new build system This PR also explicitly disallows running the workflow without CCPP, which we decided against supporting several months ago. I don't think the capability even works so this shouldn't effect anyone at this time. ## TESTS CONDUCTED: - **Cheyenne**: Build and end-to-end test ("DOT_OR_USCORE" test case) was successful on Cheyenne with intel, both for the cmake build and the old build script (that will soon be deprecated). - **Hera**: Build and end-to-end tests successful (aside from expected failures). Also built with old build script successfully. - **Jet**: Build test was successful. ## ISSUE: It was not the primary aim of this PR, but it does partially resolve NOAA-EMC#196

## DESCRIPTION OF CHANGES: This PR removes the USE_CCPP variable from all scripts and other files. The workflow only supports running the FV3 model with CCPP, so USE_CCPP is deprecated. ## TESTS CONDUCTED: Ran one WE2E test (regional_002) on hera. Succeeded. ## ISSUE (optional): This resolves Issue NOAA-EMC#196.

wx22mj and others added 12 commits August 20, 2020 14:27

20200820 Jesse Meng refactor branch of remove goto remove grib1

144a1ed

Merge pull request #1 from JesseMeng-NOAA/refactor

2624f6a

Refactor

Merge remote-tracking branch 'upstream/develop' into develop

4561a9f

20200901 Jesse Meng remove redundant LAI output in SURFCE.f

87ed987

20200901 Jesse Meng continue merging refactor to develop

7b53831

20200911 Jesse Meng add precisions to selected variables

1462143

20200911 Jesse Meng revert the precision changes

8f87f14

20200924 Jesse Meng update with EMC_post/develop

753108b

20200924 Jesse Meng update with EMC_post/develop

c9449e3

Merge remote-tracking branch 'upstream/develop' into develop

CALMICT.f: modified, keep using “go to”

861ede9

CALWXT.f: modified, use “cycle” to replace “go to”, keep several “go to” CALWXT_RAMER.f: modified, use “cycle” and “exit” to replace “go to, keep several “go to”

Improve removal of go to statements

4938dbf

Improve removal of go to statements

3117795

Improve removal of go to statements

b2a6957

Sync with upstream/develop.

3b1ffb3

Merge remote-tracking branch 'upstream/develop' into post_refactor_p1

WenMeng-NOAA requested review from HuiyaChuang-NOAA, fossell and JesseMeng-NOAA October 22, 2020 12:48

BoCui-NOAA added 3 commits October 22, 2020 13:16

Improve removal of go to statements

c2fb7ae

Merge branch 'post_refactor_p1' of github.com:WenMeng-NOAA/EMC_post i…

bd8dc0f

…nto post_refactor_p1

Improve removal of go to statements

65ed943

WenMeng-NOAA requested a review from hu5970 October 23, 2020 15:32

HuiyaChuang-NOAA reviewed Oct 23, 2020

View reviewed changes

sorc/ncep_post.fd/CALHEL.f Outdated Show resolved Hide resolved

BoCui-NOAA and others added 5 commits October 24, 2020 16:19

Improve removal of go to statements

215f645

Update code for removing goto in GSL ceiling calculations.

26588e9

The code tested with a RAPv5 case and can reproduce the results.

Merge branch 'post_refactor_p1' of https://github.com/WenMeng-NOAA/EM…

0b2ce99

…C_post into post_refactor_p1

Suggested code for removing goto.

d162bf6

Improve removal of go to statements

2c1f3a7

20201028 Bo Cui: improve removal of go to

b726281

WenMeng-NOAA and others added 9 commits October 29, 2020 12:30

Clean up the grib1 routine GRIBIT.

f2a8cb9

Add the changes from Huiya in SLP_NMM.f.

4f0f89e

Add the changes from Huiya in SLP_new.f.

e40c8de

Remove "GO TO 222" in MDL2P.f

6a15e1c

Add some tweakings in TRPAUS.f and TRPAUS_NAM.f.

1e57614

Tweaking for WETFRZLVL.f.

24e9244

clean code MDLFLD.f SERVER.f SLP_NMM.f WETBULB.f

cc7394f

Add tweaking in MDLFLD.f.

cfcedfe

Merge remote-tracking branch 'upstream/develop' into post_refactor_p1

6cb36a9

hu5970 reviewed Nov 2, 2020

View reviewed changes

sorc/ncep_post.fd/WETFRZLVL.f Show resolved Hide resolved

hu5970 reviewed Nov 2, 2020

View reviewed changes

sorc/ncep_post.fd/WETFRZLVL.f Show resolved Hide resolved

BoCui-NOAA and others added 3 commits November 2, 2020 16:18

20201102 code clean

73e966a

Add tweaking from Ming's comments.

4895f57

Merge remote-tracking branch 'upstream/develop' into post_refactor_p1

a31fdac

HuiyaChuang-NOAA approved these changes Nov 5, 2020

View reviewed changes

WenMeng-NOAA merged commit eed90f5 into NOAA-EMC:develop Nov 5, 2020

This was referenced Nov 5, 2020

Updates in branch develop #166

Closed

EMC_post_refactor to EMC_post/develop #174

Closed

JesseMeng-NOAA mentioned this pull request Nov 19, 2020

Updates with the UPP refactor phase 2 merge from Jesse Meng #229

Closed

WenMeng-NOAA deleted the post_refactor_p1 branch April 8, 2021 00:03

EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022

Modify RRFS NA 3-km cadence to produce longer forecasts (NOAA-EMC#196)

190255e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Post refactor p1 #196

Post refactor p1 #196

WenMeng-NOAA commented Oct 5, 2020

BoCui-NOAA commented Oct 13, 2020

BoCui-NOAA commented Oct 16, 2020

WenMeng-NOAA commented Oct 23, 2020

BoCui-NOAA commented Oct 28, 2020

BoCui-NOAA commented Oct 28, 2020

fossell commented Oct 28, 2020

JesseMeng-NOAA commented Oct 29, 2020 via email

WenMeng-NOAA commented Oct 29, 2020

WenMeng-NOAA commented Nov 5, 2020

Post refactor p1 #196

Post refactor p1 #196

Conversation

WenMeng-NOAA commented Oct 5, 2020

BoCui-NOAA commented Oct 13, 2020

BoCui-NOAA commented Oct 16, 2020

WenMeng-NOAA commented Oct 23, 2020

BoCui-NOAA commented Oct 28, 2020

BoCui-NOAA commented Oct 28, 2020

fossell commented Oct 28, 2020

JesseMeng-NOAA commented Oct 29, 2020 via email

WenMeng-NOAA commented Oct 29, 2020

WenMeng-NOAA commented Nov 5, 2020