EMC_post_refactor to EMC_post/develop

[JesseMeng-NOAA]

Phase 1 of refactor of remove goto remove grib1

[JesseMeng-NOAA]

Merge refactor phase 1 remove goto remove grib1 to EMC_post/develop

[WenMeng-NOAA]

Wen imported Jesse's branch merging branch "develop" under Wen's fork and renamed as "post_refactor_p1". Bo will commit new changes related to goto statement in this new branch.

[WenMeng-NOAA]

Kate's comments about grib1:
Grib1 removal comments:

Basic removal of grib1 if statements and calls to GRIBIT look ok to me
Do we need to keep the ID( ) array in the code?
Suggest removing other commented calls to GRIBIT and grib1 references
Should the GRIBIT routine itself be removed as well to keep code clean? Should perhaps at least remove from makefiles?
Consider adding more informative print statement in WRFPOST in case user tries grib1 for output format since it is now automatically set to grib2 without user knowing it.

[WenMeng-NOAA]

The UPP refactor phase 1 merge was submitted in the PR #196 and integrated in the develop at eed90d5 on 11/5/2020.

[WenMeng-NOAA]

The list of routines with goto statement changes can be found at
https://docs.google.com/spreadsheets/d/1JrMWKoEK680M0niWKfkgWW22D4mY-oyjGxOVxNvhvlQ/edit#gid=0

[fossell]

Regarding my comments on grib1 removal...was there any discussion about removing the ID() arrays from the code to clean up a bit more since those are only used for grib1?

[JesseMeng-NOAA]

Kate, In some subroutines, e.g., MDLFLD.f, ID() arrays are used to calculate time intervals and those are kept. Others were cleaned up. Thanks, Jesse ============================================== Dr. Jesse Meng IMSG at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Room 2037 College Park, MD 20740 email: [email protected] ==============================================

…

On Thu, Nov 5, 2020 at 12:45 PM Kate Fossell ***@***.***> wrote: Regarding my comments on grib1 removal...was there any discussion about removing the ID() arrays from the code to clean up a bit more since those are only used for grib1? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#174 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALXNRCP5UALIBNLQAVHA5HDSOLQETANCNFSM4QL5AO6A> .

[WenMeng-NOAA]

@fossell Jesse made some changes based on your comments and combined with the PR #196. Please let us know if you have more comments.