Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can CRTM submodule be deleted? #281

Closed
mkavulich opened this issue Mar 18, 2021 · 4 comments · Fixed by #295
Closed

Can CRTM submodule be deleted? #281

mkavulich opened this issue Mar 18, 2021 · 4 comments · Fixed by #295

Comments

@mkavulich
Copy link
Contributor

The CRTM submodule on the develop branch is no longer used by the DTC build (the CRTM code is contained in NCEPLIBS and the CRTM fix files are now downloaded separately). Does anyone else make use of this submodule, or can it be deleted from the develop branch?
@fossell
Copy link
Contributor

fossell commented Mar 18, 2021

@mkavulich No, this was only for DTC. It can be removed.

@WenMeng-NOAA
Copy link
Collaborator

@mkavulich and @fossell For NCEP implementation, we use CRTM from the dev. hpc-stack or NCEP ops. libraries sites.

@WenMeng-NOAA
Copy link
Collaborator

@mkavulich and @fossell Is the solution of this issue included in the PR #295?

@fossell
Copy link
Contributor

fossell commented Apr 12, 2021

@WenMeng-NOAA - Yes, I will try to finish that PR up today.

@fossell fossell linked a pull request Apr 12, 2021 that will close this issue
Merge public v2 #295
Merged
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@gsketefian
Remove redundant model_configure.${CCPP_PHYS_SUITE} template files; u…
2163fb3 
…se Jinja2 to create model_configure (NOAA-EMC#321)

## DESCRIPTION OF CHANGES:
* Remove model_configure template files whose names depend on the physics suite, i.e. files with names of the form model_configure.${CCPP_PHYS_SUITE}.  Only a single template file is needed because the contents of the model_configure file are not suite dependent.  This leaves just one template file (named model_configure).
* Change the function create_model_configure_file.sh and the template file model_configure so they use jinja2 instead of sed to replace placeholder values.
* Absorb the contents of the write-component template files wrtcmp_lambert_conformal, wrtcmp_regional_latlon, and wrtcmp_rotated_latlon into the new jinja2-compliant model_configure file.  We can do this because Jinja2 allows use of if-statements in the template file.
* In the new model_configure jinja2 template file, include comments to explain the various write-component parameters.

## TESTS CONDUCTED:
On Hera, ran the two WE2E tests new_ESGgrid and new_GFDLgrid.  The first uses a "lambert_conformal" type of write-component grid, and the second uses a "rotated_latlon" type of write-component grid.  (The write-component also allows "regional_latlon" type grids, which is just the usual earth-relative latlon coordinate system, but we do not have any cases that use that.)  Both tests succeeded.

## ISSUE (optional): 
This PR resolves issue NOAA-EMC#281.
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@hu5970
1) Add function to update snow and ice based on ims snow observations. (
fc83672 
NOAA-EMC#281)

2) remove namelist for NST because it is removed from FV3_HRRR physics suite.
3) use nord=3 and d4_bg=0.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge public v2 fossell/UPP
3 participants
@mkavulich @fossell @WenMeng-NOAA