-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmake build with GTG code #272
Comments
@YaliMao-NOAA Please see the compiling errors from gtg code above. |
Kate, |
The lowercase |
@YaliMao-NOAA Could you try Kyle's suggestion for changing gtg code from |
@YaliMao-NOAA You may find the instruction of build UPP via camke at |
@kgerheiser I was able to duplicate the error messages as Kate did, so I took your suggestion. After changing the file extensions from f90 to F90 and modifying sorc/ncep_post.fd/CMakeLists.txt, I ran into another error message: GDSWZD_MOD comes from module ip: Looking into tests/build/sorc/ncep_post.fd/CMakeFiles/upp.dir/flags.make, I didn't see ip/3.3.3/include_4 included in Fortran_INCLUDES. Is this the reason why I got the error message as above? |
Is there a missing |
@kgerheiser Are you talking about cmake/PackageConfig.cmake.in? There is a line: |
@kgerheiser May you please take a look when you get a chance? The package is on Venus at /gpfs/dell2/emc/modeling/noscrub/Yali.Mao/git/EMC_post_wafs. ip/v3.3.3 is loaded successfully, somehow IP_INC4 is not included in Fortran_INCLUDES for compiling. Thank you! |
Is there a branch or somewhere I can get the code from and build myself? |
@kgerheiser I followed Wen's instruction earlier, https://github.com/NOAA-EMC/EMC_post/wiki/Building-UPP#build-standalone-upp-via-cmake. |
@kgerheiser Hi Kyle, not sure whether you caught the message earlier. I have a copy of UPP GTG code on Venus at /gpfs/dell2/emc/modeling/noscrub/Yali.Mao/git/EMC_post_wafs. There are two differences from the general UPP that you can clone from github.
|
You need an The library no longer links to ip because of the OpenMP dependency, but now it needs to compile with it. |
@kgerheiser Great! It works now. Thank you for your help. |
With adding the change you suggest, I tested upp lib building with stub gtg code and didn't see -qopenmp in the compiling log. I would assume this change would not have impact on the upp lib building with openmp disabled, right? |
I expected OpenMP to propagate to UPP if you link to |
@kgerheiser Both Wen and I ran into runtime error on Hera, while Wen got runtime error on Dell but I didn't. So I debugged on Hera, found a temporary fix but I really doubt the runtime error coming from cmake compiling, which doesn't handle optional arguments well. Error messages as shown in /scratch2/NCEPDEV/stmp3/Yali.Mao/run_gfs_post.oe18041469
I have a jobcard and you can just modify it for your test run:
Please re-run the jobcard again.
|
1. Fix buzillar #1207 http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1207 2. EMC_post issue NOAA-EMC#272
* To make 'cmake' go through for GTG, 1. GTG source code file extensions are changed from f90 to F90 2. Add ip::ip_4 back to sorc/ncep_post.fd/CMakeLists.txt * Made a new tag of NCAR GTG to change file extension from f90 to F90, then updated Externals.cfg with this new tag * Update GTG tag to fix two issues: 1. Fix buzillar #1207 http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1207 2. EMC_post issue #272
* To make 'cmake' go through for GTG, 1. GTG source code file extensions are changed from f90 to F90 2. Add ip::ip_4 back to sorc/ncep_post.fd/CMakeLists.txt * Made a new tag of NCAR GTG to change file extension from f90 to F90, then updated Externals.cfg with this new tag * Update GTG tag to fix two issues: 1. Fix buzillar #1207 http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1207 2. EMC_post issue #272 * Pick up GTG new tag fixing the failure because of strong wind * Add debug mode option to tests/compile_upp.sh --------- Co-authored-by: wx20yam <[email protected]> Co-authored-by: yali mao <[email protected]>
The current EMC_post develop branch does not build with GTG code.
Tried to build develop (33eb60e) on WCOSS-Dell with GTG code copied in; build failed:
/gpfs/dell2/emc/modeling/save/Kate.Friedman/git/global-workflow/feature-hpc-stack/sorc/logs/build_ncep_post_33eb60e.log
The text was updated successfully, but these errors were encountered: