Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require CMake>=3.18 #260

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Require CMake>=3.18 #260

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73a6a73
CMakeLists.txt: minimum cmake 3.18 (LAPACK::LAPACK)
AlexanderRichert-NOAA Nov 21, 2024
1b00a35
package.py: minimum cmake=3.18
AlexanderRichert-NOAA Nov 21, 2024
5f22b4a
developer.yml: gcovr --gcov-ignore-parse-errors
AlexanderRichert-NOAA Nov 22, 2024
6c694f7
developer.yml: use gcovr==7.2; revert --gcov-ignore-parse-errors
AlexanderRichert-NOAA Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/developer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: ctest --test-dir ip/build -j2 --verbose --output-on-failure --rerun-failed

- name: run-gcovr
run: gcovr -r ip -v --html-details --exclude ip/tests --exclude ip/build/CMakeFiles --print-summary -o test-coverage.html
run: gcovr -r ip -v --html-details --exclude ip/tests --exclude ip/build/CMakeFiles --gcov-ignore-parse-errors --print-summary -o test-coverage.html

- name: upload-test-coverage
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This is the main CMake file for NCEPLIBS-ip.
#
# Mark Potts, Kyle Gerheiser, Eric Engle, Ed Hartnett
cmake_minimum_required(VERSION 3.15)
# Mark Potts, Kyle Gerheiser, Eric Engle, Ed Hartnett, Alex Richert
cmake_minimum_required(VERSION 3.18)

# Get the version from the VERSION file.
file(STRINGS "VERSION" pVersion)
Expand Down
1 change: 1 addition & 0 deletions spack/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class Ip(CMakePackage):
depends_on("sp precision=d", when="@4.1:4 precision=d")
depends_on("sp precision=8", when="@4.1:4 precision=8")
depends_on("lapack", when="@5.1:")
depends_on("[email protected]:", when="@5.1:")

def cmake_args(self):
args = [
Expand Down
Loading