Require CMake>=3.18 #260
Merged
Require CMake>=3.18 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardhartnett @AlysonStahl-NOAA @Hang-Lei-NOAA have you guys run into one of these "suspicious hit" failures with gcovr? https://github.com/NOAA-EMC/NCEPLIBS-ip/actions/runs/11963380013/job/33353708489?pr=260 |
|
No I've never seen that gcovr error. Have you tried using the recommended flag? |
AlexanderRichert-NOAA
requested review from
edwardhartnett and
Hang-Lei-NOAA
Hang-Lei-NOAA
approved these changes
Nov 22, 2024
|
That resolves the failure, but it seems to be reporting lines as missing that shouldn't be. I'll see if maybe it's a version thing. |
|
It could be a special failure associated with compiler. Gcover is used in
landcover mapping, and should be a stable component.
…On Fri, Nov 22, 2024 at 4:39 PM Alex Richert ***@***.***> wrote:
That resolves the failure, but it seems to be reporting lines as missing
that shouldn't be. I'll see if maybe it's a version thing.
—
Reply to this email directly, view it on GitHub
<#260 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKWSMFFSIB7D4SGFJCNVQMD2B6QBZAVCNFSM6AAAAABSIEEBMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJUHA4TQOBZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Reverting to gcovr 7.2 fixed it (8.2 was the one that was failing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAPACK::LAPACK target is only available in cmake 3.18.0+.
Fixes #258