-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates detect_machines.sh
to be consistent with UFSWM
#890
Updates detect_machines.sh
to be consistent with UFSWM
#890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
@guillaumevernieres and @CoryMartin-NOAA : This PR contains a critical change to the GDAS hera modulefile.
We need to move to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HenryWinterbottom-NOAA .
Clone |
This PR addresses issue #889. The following is accomplished:
ush/detect_machine.sh
is replaced by the UFS weather-modeltests/detect_machine.sh
prepared by @BrianCurtis-NOAA;rocoto
has been updated from1.3.3
to1.3.6
to allow the build system to complete successfully.This PR does not modify any applications with the GDASApp, only the determination of the respective host. No CI/CD or regression testing should be required.