Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detect_machine.sh to be consistent with UFSWM #889

Closed
RussTreadon-NOAA opened this issue Jan 31, 2024 · 9 comments
Closed

Update detect_machine.sh to be consistent with UFSWM #889

RussTreadon-NOAA opened this issue Jan 31, 2024 · 9 comments
Assignees
@HenryRWinterbottom

Comments

@RussTreadon-NOAA
Copy link
Contributor

GDASApp has a copy of detect_machine.sh which is not consistent with detect_machine.sh in GSI PR #691. This issue is opened to work with the g-w team to get the correct detect_machine.sh in GDASApp ush/.
@RussTreadon-NOAA
Copy link
Contributor Author

@HenryWinterbottom-NOAA and @aerorahul : from where do we get the official `detect_machine.sh which all EMC repos should be using?

@aerorahul
Copy link
Contributor

@RussTreadon-NOAA Since the UFS-weather-model is usually the first component to be ported to a new system, we are treating it as the source for detect_machine.sh.
There is a PR in the ufs-weather-model under review at https://github.com/ufs-community/ufs-weather-model/pull/2111/files
One can grab that file from that PR or the global-workflow PR NOAA-EMC/global-workflow#2252

@RussTreadon-NOAA
Copy link
Contributor Author

Thanks @aerorahul . @HenryWinterbottom-NOAA , shall I assign this issue to you for action at your convenience?

@HenryRWinterbottom
Copy link
Contributor

@RussTreadon-NOAA Do you mean, as the detect_machine.sh changes within the UFSWM, I am responsible for updating the necessary GW submodules (including the GSI)?

If so, yes -- please assign to me.

@RussTreadon-NOAA
Copy link
Contributor Author

@HenryWinterbottom-NOAA , GDASApp is cloned as a submodule from GW develop so I guess updating ush/detect_machine.sh in GDASApp is within the scope of what you are working on. Feel free to correct me if I'm wrong.

@RussTreadon-NOAA
Copy link
Contributor Author

Assigning this issue to @HenryWinterbottom-NOAA . If this isn't within the scope of your work, reassign to me and I'll work with others to figure out how to proceed.

@aerorahul
Copy link
Contributor

I think @HenryWinterbottom-NOAA can/will make a PR in the GDASapp when he is done with the other components.

@RussTreadon-NOAA
Copy link
Contributor Author

Great! Thank you @aerorahul and @HenryWinterbottom-NOAA

@HenryRWinterbottom HenryRWinterbottom mentioned this issue Jan 31, 2024
Merged
RussTreadon-NOAA pushed a commit that referenced this issue Jan 31, 2024
@HenryRWinterbottom @henrywinterbottom-wxdev
Updates detect_machines.sh to be consistent with UFSWM (#890)
0ebe826 
This PR addresses issue #889. The following is accomplished:

- The GDASApp `ush/detect_machine.sh` is replaced by the UFS
weather-model `tests/detect_machine.sh` prepared by @BrianCurtis-NOAA;
- The version of `rocoto` has been updated from `1.3.3` to `1.3.6` to
allow the build system to complete successfully.

This PR does not modify any applications with the GDASApp, only the
determination of the respective host. No CI/CD or regression testing
should be required.

---------

Co-authored-by: henrywinterbottom-wxdev <[email protected]>
@RussTreadon-NOAA
Copy link
Contributor Author

Close with merger of PR #890 into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenryRWinterbottom HenryRWinterbottom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aerorahul @RussTreadon-NOAA @HenryRWinterbottom