.NET Core 3.1 + NET 5 Support

[304NotModified]

resolves #39

works locally in test application

todo:

• Add .NET Core 3
• Add .NET 5
• fix clicking link in .NET 5
• disabled SupportLinks for .NET Core 3, but not for .NET 5
• run unit tests for all platforms
• run unit tests for all platforms in CI (AppVeyor) -> started
• fix issues in other platforms, see unit tests
• disable the linkclick tests for .NET core 3
• move to .NET Core 3.1 instead of 3.0

[304NotModified]

hyperlinks won't work well

This is an issue with the selection range?

expected:

without change:

with change in PR (still no good)

[Logerfo]

Have you tried the preview 8 yet? Don't know if it will help but it might be worth a shot...

[304NotModified]

I think I did, as preview 8 is production ready according to MS. I have to check that.

[Logerfo]

Take a look at dotnet/winforms#1631.

[304NotModified]

ah thanks!

[Logerfo]

If that was indeed the problem, dotnet/winforms#1745 was merged today and will be available through the .NET Core 3.0 GA, which will be released at .NET Conference later this month (between September 23th and 25th).

[304NotModified]

Nice!

It isn't fixed in preview 9?

[Logerfo]

I don't think so, the merge happened a few hours later than the release announcement. Perhaps you could try it with the master "5.0" SDK, but I don't know how to do that.

[Logerfo]

I think that would help if you want to try: https://github.com/dotnet/coreclr#using-your-build

[Logerfo]

.NET Core 3.0 RC1 is up, did you have a chance to try it out yet?

[304NotModified]

Will try to test soon. If you have time, please test it, the case is really easy to see (just start the netcore3 app) - that would be very helpful :)

I'm now on holiday so a bit limited.

(The last test was with preview 9)

[Logerfo]

Running with RC1:

[Logerfo]

I think that an issue with a proper minimum reproduction should be opened at dotnet/winforms. I'm not going to do that because I'm not fully aware of stuff. I don't use this package with RTF. Actually, I don't use RTF at all, so this hyperlink syntax seems out of place for me. Nevertheless, this will not be fixed before the GA release.

[304NotModified]

Unfortunately I don't know if it is a bug in our code or Microsoft's

That needs an investigation

[Logerfo]

Tested against .NET Core 3.1 Preview 1: same behavior.

[weltkante]

Here is what it would look like to not set a fixed font and instead branch the tests. You might have to add if (IsAppVeyor) conditionals into the .NET Core conditionals as well if font sizes differ here. Can't test that since, in fact, my setup seems to be matching the AppVeyor setup. You mave have changed your default font size on your local machine?

The \f1 that disappears in .NET Core is because on Desktop Framework there are two fonts in the font table (\f0 and \f1) while in .NET Core (with default settings) there is only one font, so there is no switching between fonts in the .NET Core markup.

[weltkante]

Did a mistake in my original tests, the officially documented hyperlink markup actually works in .NET 5 (the native control does all the work, WinForms isn't involved) - switching the link generation to not use hidden text means we don't have to wait for a fix for WinForms to pass hidden text to the LinkClicked handler.

[kirsan31]

@304NotModified

move to .NET Core 3.1 instead of 3?

I think yes, only NET 5 and .NET Core 3.1 are actual.

@weltkante
Thank you once more, your are the best, as always 😉

[304NotModified]

I'm not really a fan of hardcoding fonts over the OS default anyways, but I'm not sure how to test that then. Any suggestion how to proceed?

I think it would be nice to have fixed fonts for the tests, and only for the tests.

You mave have changed your default font size on your local machine?

No, but maybe the zoom factor is also related?

[weltkante]

Since I've already been halfway there I've also ported the RichTextBox.Text accessor fix from .NET 5 (which returns hidden text instead of suppressing it and therefore messing up indexing) into a standalone method. This makes links generate properly in .NET Core 3.x as well I believe, but I didn't test it extensively, the tests certainly pass. Your choice if you want that additional interop for working around a .NET Core 3.x bug, or just declare it not supported.

Technically you can use that on .NET 4.7+ as well but considering that there is a runtime switch to decide which RTF control to use it would probably get pretty hacky to figure out which RTF control is used. Certainly not enough to have static #if compile time switching between the strategies on Desktop Framework, you have to actually check in which version the RTF control is running and then select dynamically.

[304NotModified]

I think yes, only NET 5 and .NET Core 3.1 are actual.

Ow yes indeed, EOL 2020-03-03. At work we are already at 3.1/5.0 😅

[weltkante]

I think it would be nice to have fixed fonts for the tests, and only for the tests.

Any idea how to configure the font of the dynamically generated form? Would certainly simplify the tests a lot.

but maybe the zoom factor is also related?

Perhaps, it certainly complicates the tests (I have to switch the tests to run with AppVeyor settings because whatever is the standard on your side isn't for me).

[304NotModified]

Any idea how to configure the font of the dynamically generated form? Would certainly simplify the tests a lot.

Well we could make it an option of the target (the font size) and then set a fixed from the tests?

[304NotModified]

It took some time, but it's finally merged :)

Thanks you guys!!

[304NotModified]

It's published as 4.5.0-rc.1: https://www.nuget.org/packages/NLog.Windows.Forms/4.5.0-rc.1