Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target support for .net core 3.0 #39

Closed
Logerfo opened this issue Dec 5, 2018 · 6 comments · Fixed by #42
Closed

Target support for .net core 3.0 #39

Logerfo opened this issue Dec 5, 2018 · 6 comments · Fixed by #42
Labels
feature

Comments

@Logerfo
Copy link

Logerfo commented Dec 5, 2018

Warning NU1701 Package 'NLog.Windows.Forms 4.2.3' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v3.0'. This package may not be fully compatible with your project.
@304NotModified
Copy link
Member

PR would be great for this!

@304NotModified 304NotModified mentioned this issue Jun 11, 2019
Merged
@304NotModified
Copy link
Member

304NotModified commented Jun 17, 2019 •
edited
Loading

Hi!

I've created a port locally. I think work, but haven't got it working on the CI

The package: (remove .zip from the name)

NLog.Windows.Forms.4.4.0-beta1.nupkg.zip

@304NotModified 304NotModified mentioned this issue Jun 17, 2019
Merged
9 tasks
@Logerfo
Copy link
Author

Logerfo commented Jun 18, 2019

Thanks! I'm currently postponing migrating to .NET Core 3.0 to a couple of months, but will try it out as soon as I get back to it.

@304NotModified
Copy link
Member

👍 please let me know if you have any feedback (positive and/or negative)

@Logerfo
Copy link
Author

Logerfo commented Aug 26, 2019

Alright, this seems to be working just fine. :shipit:

@304NotModified
Copy link
Member

304NotModified commented Aug 26, 2019 •
edited
Loading

Unfortunately I found an issue, see #42 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.NET Core 3.1 + NET 5 Support NLog/NLog.Windows.Forms
2 participants
@304NotModified @Logerfo