Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/docs minor issues #250

Merged
merged 11 commits into from
Jun 28, 2023
Merged

Fix/docs minor issues #250

merged 11 commits into from
Jun 28, 2023

Conversation

georgeyiasemis
Copy link
Contributor

Minor code fixes:

  • Fix transforms creation for inference using dict_flatten

Config fixes:

  • Update projects/ to new transforms config:
cropping:
    crop: null
sensitivity_map_estimation:
    estimate_sensitivity_maps: true  # Estimate the sensitivity map on the ACS
normalization:
    scaling_key: masked_kspace

Documentation fixes:

  • Update some documentation files

@github-actions github-actions bot added documentation Improvements or additions to documentation python labels Jun 25, 2023
This was linked to issues Jun 25, 2023
First time trying out the package #243
Closed
URL is dead #244
Closed
Typo in example dataset class? #245
Closed
Missing variables in MyNewDataset #246
Closed
Add import in datasets_config.py #247
Closed
Update on the config.yaml of the pretrained unet #249
Closed
@codecov
Copy link

codecov bot commented Jun 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 92.00% and project coverage change: +0.05 🎉

Comparison is base (b380e2e) 83.88% compared to head (5fabb65) 83.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   83.88%   83.93%   +0.05%     
==========================================
  Files          91       91              
  Lines        6278     6298      +20     
==========================================
+ Hits         5266     5286      +20     
  Misses       1012     1012
Impacted Files Coverage Δ
direct/inference.py 0.00% <0.00%> (ø)
direct/data/datasets_config.py 100.00% <100.00%> (ø)
direct/data/mri_transforms.py 92.32% <100.00%> (+0.03%) ⬆️
direct/types.py 90.00% <100.00%> (+5.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jonasteuwen
jonasteuwen approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit 2a4c293 into main Jun 28, 2023
@jonasteuwen jonasteuwen deleted the fix/docs-minor-issues branch June 28, 2023 14:12
georgeyiasemis added a commit to georgeyiasemis/direct-ssl that referenced this pull request Aug 31, 2023
@georgeyiasemis
Minor Code and Documentation Fixes (NKI-AI#250, closes NKI-AI#243, NK…
e3cca85 
…I-AI#244, NKI-AI#245, NKI-AI#246, NKI-AI#247, NKI-AI#249) (#3)

Minor code fixes:
* Fix transforms creation for inference using `dict_flatten`

Config fixes:
* Update projects/<configs>  to new transforms config:
``` 
cropping:
    crop: null
sensitivity_map_estimation:
    estimate_sensitivity_maps: true  # Estimate the sensitivity map on the ACS
normalization:
    scaling_key: masked_kspace
```

Documentation fixes:
* Update some documentation files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python
Projects
None yet
Milestone
No milestone
2 participants
@georgeyiasemis @jonasteuwen