Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in example dataset class? #245

Closed
zwep opened this issue May 11, 2023 · 0 comments · Fixed by #250
Closed

Typo in example dataset class? #245

zwep opened this issue May 11, 2023 · 0 comments · Fixed by #250
Labels
bug Something isn't working

Comments

@zwep
Copy link

zwep commented May 11, 2023

Describe the bug

On the page https://docs.aiforoncology.nl/direct/datasets.html there is an example class called 'MyNewDataset'.

There a method is called 'def self.get_dataset_len(self):' which I think should be something like 'def get_dataset_len(self):'

To Reproduce
Go to https://docs.aiforoncology.nl/direct/datasets.html
Check the example dataset implementation

Expected behavior
I expect def get_dataset_len(self): as method definition

Environment
dlup version: Not installed.
direct version: 1.0.5.dev0
How installed: using conda
Python version: 3.9
Operating System:
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye

Additional context
Add any other context about the problem here.
@zwep zwep added the bug Something isn't working label May 11, 2023
@georgeyiasemis georgeyiasemis linked a pull request Jun 25, 2023 that will close this issue
Fix/docs minor issues #250
Merged
jonasteuwen pushed a commit that referenced this issue Jun 28, 2023
@georgeyiasemis
Minor Code and Documentation Fixes (#250, closes #243, #244, #245, #246…
2a4c293 
…, #247, #249)

Minor code fixes:
* Fix transforms creation for inference using `dict_flatten`

Config fixes:
* Update projects/<configs>  to new transforms config:
``` 
cropping:
    crop: null
sensitivity_map_estimation:
    estimate_sensitivity_maps: true  # Estimate the sensitivity map on the ACS
normalization:
    scaling_key: masked_kspace
```

Documentation fixes:
* Update some documentation files
georgeyiasemis added a commit to georgeyiasemis/direct-ssl that referenced this issue Aug 31, 2023
@georgeyiasemis
Minor Code and Documentation Fixes (NKI-AI#250, closes NKI-AI#243, NK…
e3cca85 
…I-AI#244, NKI-AI#245, NKI-AI#246, NKI-AI#247, NKI-AI#249) (#3)

Minor code fixes:
* Fix transforms creation for inference using `dict_flatten`

Config fixes:
* Update projects/<configs>  to new transforms config:
``` 
cropping:
    crop: null
sensitivity_map_estimation:
    estimate_sensitivity_maps: true  # Estimate the sensitivity map on the ACS
normalization:
    scaling_key: masked_kspace
```

Documentation fixes:
* Update some documentation files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/docs minor issues NKI-AI/direct
1 participant
@zwep