Skip to content

Commit

Permalink
code review
Browse files Browse the repository at this point in the history
  • Loading branch information
bshand committed Nov 21, 2024
1 parent 6c6c33c commit cd361f5
Showing 1 changed file with 21 additions and 17 deletions.
38 changes: 21 additions & 17 deletions code_safety.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ file safety:
".github/workflows/test.yml":
comments:
reviewed_by: brian.shand
safe_revision: 7793a9f2f74f0acef108c541d9df64dc16798bc2
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
".gitignore":
comments:
reviewed_by: josh.pencheon
Expand All @@ -23,11 +23,11 @@ file safety:
".rubocop.yml":
comments:
reviewed_by: brian.shand
safe_revision: 6677736f0d095dcc14e79dfea3b317178ca65070
safe_revision: 6f360472ed5b7fd0836f5f522f3517bc3e0bbb89
CHANGELOG.md:
comments:
reviewed_by: brian.shand
safe_revision: 71c40edb16ca5068278ae2f5f8f9b595be0fd0e1
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
CODE_OF_CONDUCT.md:
comments:
reviewed_by: Miles Smith
Expand Down Expand Up @@ -115,18 +115,22 @@ file safety:
comments:
reviewed_by: josh.pencheon
safe_revision: f29ceeca988132c58bb38c7ba3d85c38252aded5
gemfiles/Gemfile.rails60:
comments:
reviewed_by: josh.pencheon
safe_revision: deb386d3e2088d974c4dd3c9d8292e7ff8c07228
gemfiles/Gemfile.rails61:
comments:
reviewed_by: brian.shand
safe_revision: f538c9dc6398af2823dc5ff9052b0527c26253e7
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
gemfiles/Gemfile.rails70:
comments:
reviewed_by: brian.shand
safe_revision: bbdd29b364a7151de4ad704c77c0936132e640ec
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
gemfiles/Gemfile.rails71:
comments:
reviewed_by: brian.shand
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
gemfiles/Gemfile.rails72:
comments:
reviewed_by: brian.shand
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
lib/ndr_error.rb:
comments: Potentially dangerous defaults. Default configuration assumes any given
user is both authenticated and authorized to read/update/delete any error. JMP
Expand Down Expand Up @@ -172,15 +176,15 @@ file safety:
lib/ndr_error/version.rb:
comments:
reviewed_by: brian.shand
safe_revision: 6fbef03cf526b2838d75b5c0b847d36e1f41a43e
safe_revision: 180d26d43236a5f3b8210e1b857f7c5abeddec6f
lib/tasks/ndr_error_tasks.rake:
comments:
reviewed_by: Miles Smith
safe_revision: 6b335dd1e823dffecb0d2c936e11b81edff0b067
ndr_error.gemspec:
comments:
reviewed_by: brian.shand
safe_revision: 71c40edb16ca5068278ae2f5f8f9b595be0fd0e1
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
script/rails:
comments:
reviewed_by: Miles Smith
Expand Down Expand Up @@ -239,8 +243,8 @@ file safety:
safe_revision: ae18bbbff14d543b9a04e0c2b6158de66fb39772
test/dummy/config/application.rb:
comments:
reviewed_by: josh.pencheon
safe_revision: 3a90be07bc39458e0d712d67d6ad749d47c1a0f1
reviewed_by: brian.shand
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
test/dummy/config/boot.rb:
comments:
reviewed_by: Miles Smith
Expand All @@ -255,8 +259,8 @@ file safety:
safe_revision: 6b335dd1e823dffecb0d2c936e11b81edff0b067
test/dummy/config/environments/test.rb:
comments:
reviewed_by: josh.pencheon
safe_revision: baff8a5a455103dcf5ad8019fd294ada391b8656
reviewed_by: brian.shand
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
test/dummy/config/initializers/backtrace_silencers.rb:
comments:
reviewed_by: Miles Smith
Expand Down Expand Up @@ -367,8 +371,8 @@ file safety:
safe_revision: 0a8e49f503ec8ca2f839a976919c299c9a3b65f0
test/unit/ndr_error/log_test.rb:
comments:
reviewed_by: josh.pencheon
safe_revision: 0c8ae75d4cba713cc45dca3d94734fa77f170a82
reviewed_by: brian.shand
safe_revision: 6c6c33cfa43cf89b18a122c131f1c01bceb1386f
test/unit/ndr_error/logging_test.rb:
comments:
reviewed_by: josh.pencheon
Expand Down

0 comments on commit cd361f5

Please sign in to comment.