New: [AEA-4488] - Adds NPPTS Slack Alerts #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackSpagnoliNHS
had a problem deploying
to
dev
GitHub Actions
Failure
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
had a problem deploying
to
dev
GitHub Actions
Failure
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
had a problem deploying
to
dev
GitHub Actions
Failure
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Orkastrated
reviewed
Oct 4, 2024
SAMtemplates/alarms/main.yaml
Outdated
| Type: AWS::CloudWatch::Alarm | ||
| Properties: | ||
| AlarmDescription: Count of CPSU FHIR Converter errors | ||
| AlarmName: !Sub ${StackName}_CPSU_FHIR_Converter_Errors |
There was a problem hiding this comment.
So i think the extra underscores in the alarm name will end up with the alarm name coming through to slack being a bit wrong, may need to concat the middle section so it ends up something like ${StackName}_CpsuFhirConverter_Errors
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
wildjames
reviewed
Oct 4, 2024
| @@ -30,7 +30,7 @@ Parameters: | |||
| EnableSplunk: | |||
| Type: String | |||
|
|
|||
| FihrValidatorStackName: | |||
| FhirValidatorStackName: | |||
There was a problem hiding this comment.
Awestruck that you spotted this
There was a problem hiding this comment.
I would take the credit but I only saw it when cloudformation kicked off when I tried to import it spelt correctly 😹
wildjames
approved these changes
Oct 4, 2024
|
JackSpagnoliNHS
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JackSpagnoliNHS
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Adds NPPTS Slack Alerts