New: [AEA-4488] - Adds NPPTS Slack Alerts (#869)

## Summary - ✨ New Feature ### Details Adds NPPTS Slack Alerts
NHSDigital · Oct 4, 2024 · ec8cd8f · ec8cd8f
1 parent c7636ff
commit ec8cd8f
Show file tree

Hide file tree

Showing 3 changed files with 187 additions and 5 deletions.
diff --git a/SAMtemplates/alarms/main.yaml b/SAMtemplates/alarms/main.yaml
@@ -6,12 +6,19 @@ Description: |
 Parameters:
   StackName:
     Type: String
-    Default: none
 
   GetStatusUpdatesFunctionName:
     Type: String
-    Default: none
+
+  UpdatePrescriptionStatusFunctionName:
+    Type: String
+
+  PrescriptionStatusUpdatesTableName:
+    Type: String
 
+  ConvertRequestToFhirFormatFunctionName:
+    Type: String
+
   EnableAlerts:
     Type: String
 
@@ -81,3 +88,175 @@ Resources:
         - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
       OKActions:
         - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+
+  PrescriptionStatusUpdateErrorsLogsMetricFilter:
+    Type: AWS::Logs::MetricFilter
+    Properties:
+      FilterName: PrescriptionStatusUpdateErrors
+      FilterPattern: !Sub '{ ($.function_name = "${UpdatePrescriptionStatusFunctionName}") && ($.response.statusCode = 500) }'
+      LogGroupName:
+        Fn::ImportValue: !Sub ${StackName}:functions:${UpdatePrescriptionStatusFunctionName}:LambdaLogGroupName
+      MetricTransformations:
+        - MetricNamespace: LambdaLogFilterMetrics
+          MetricName: ErrorCount
+          MetricValue: 1
+          Unit: Count
+          Dimensions:
+            - Key: FunctionName
+              Value: $.function_name
+
+  # Count of errors forced by INT tests
+  PrescriptionStatusUpdateForcedErrorsLogsMetricFilter:
+    Type: AWS::Logs::MetricFilter
+    Properties:
+      FilterName: PrescriptionStatusUpdateForcedErrors
+      FilterPattern: !Sub '{ ($.level = "INFO") && ($.function_name = "${UpdatePrescriptionStatusFunctionName}") && ($.message = %Forcing error for INT test prescription%) }'
+      LogGroupName:
+        Fn::ImportValue: !Sub ${StackName}:functions:${UpdatePrescriptionStatusFunctionName}:LambdaLogGroupName
+      MetricTransformations:
+        - MetricNamespace: LambdaLogFilterMetrics
+          MetricName: ForcedErrorCount
+          MetricValue: 1
+          Unit: Count
+          Dimensions:
+            - Key: FunctionName
+              Value: $.function_name
+
+  PrescriptionStatusUpdateErrorsAlarm:
+    Type: AWS::CloudWatch::Alarm
+    Properties:
+      AlarmDescription: Count of PrescriptionStatusUpdate errors
+      AlarmName: !Sub ${StackName}_PrescriptionStatusUpdate_Errors
+      Metrics:
+        - Id: errors
+          Label: All 500 errors
+          ReturnData: false
+          MetricStat:
+            Metric:
+              MetricName: ErrorCount
+              Namespace: LambdaLogFilterMetrics
+              Dimensions:
+                - Name: FunctionName
+                  Value: !Ref UpdatePrescriptionStatusFunctionName
+            Period: 60
+            Stat: Sum
+            Unit: Count
+        - Id: forcedErrors
+          Label: Forced 500 errors
+          ReturnData: false
+          MetricStat:
+            Metric:
+              MetricName: ForcedErrorCount
+              Namespace: LambdaLogFilterMetrics
+              Dimensions:
+                - Name: FunctionName
+                  Value: !Ref UpdatePrescriptionStatusFunctionName
+            Period: 60
+            Stat: Sum
+            Unit: Count
+        - Id: trueErrors
+          Label: True 500 errors
+          Expression: errors - forcedErrors
+          ReturnData: true
+      EvaluationPeriods: 1
+      ComparisonOperator: GreaterThanOrEqualToThreshold
+      Threshold: 1
+      TreatMissingData: notBreaching
+      ActionsEnabled: !Ref EnableAlerts
+      AlarmActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      InsufficientDataActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      OKActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+
+  PrescriptionStatusUpdateUnhandledErrorsAlarm:
+    Type: AWS::CloudWatch::Alarm
+    Properties:
+      AlarmDescription: Count of PrescriptionStatusUpdate unhandled errors
+      AlarmName: !Sub ${StackName}_PrescriptionStatusUpdate_UnhandledErrors
+      Namespace: Lambda
+      MetricName: Errors
+      Dimensions:
+        - Name: FunctionName
+          Value: !Ref UpdatePrescriptionStatusFunctionName
+      Period: 60 #seconds
+      EvaluationPeriods: 1
+      Statistic: Sum
+      ComparisonOperator: GreaterThanOrEqualToThreshold
+      Threshold: 1
+      Unit: Count
+      TreatMissingData: notBreaching
+      ActionsEnabled: !Ref EnableAlerts
+      AlarmActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      InsufficientDataActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      OKActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+
+  DynamoDBSystemErrorsAlarm:
+    Type: AWS::CloudWatch::Alarm
+    Properties:
+      AlarmDescription: Count of DynamoDB system errors
+      AlarmName: !Sub ${StackName}_DynamoDB_SystemErrors
+      Namespace: DynamoDB
+      MetricName: SystemErrors
+      Dimensions:
+        - Name: TableName
+          Value: !Ref PrescriptionStatusUpdatesTableName
+      Period: 60 #seconds
+      EvaluationPeriods: 1
+      Statistic: Sum
+      ComparisonOperator: GreaterThanOrEqualToThreshold
+      Threshold: 1
+      Unit: Count
+      TreatMissingData: notBreaching
+      ActionsEnabled: !Ref EnableAlerts
+      AlarmActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      InsufficientDataActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      OKActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+
+  CPSUFhirConverterErrorLogsMetricFilter:
+    Type: AWS::Logs::MetricFilter
+    Properties:
+      FilterName: CPSUFhirConverterErrors
+      FilterPattern: !Sub '{ ($.function_name = "${ConvertRequestToFhirFormatFunctionName}") && ($.response.statusCode = 500) }'
+      LogGroupName:
+        Fn::ImportValue: !Sub ${StackName}:functions:${ConvertRequestToFhirFormatFunctionName}:LambdaLogGroupName
+      MetricTransformations:
+        - MetricNamespace: LambdaLogFilterMetrics
+          MetricName: ErrorCount
+          MetricValue: 1
+          Unit: Count
+          Dimensions:
+            - Key: FunctionName
+              Value: $.function_name
+
+  CPSUFhirConverterErrorsAlarm:
+    Type: AWS::CloudWatch::Alarm
+    Properties:
+      AlarmDescription: Count of CPSU FHIR Converter errors
+      AlarmName: !Sub ${StackName}_CpsuFhirConverter_Errors
+      Namespace: Lambda
+      MetricName: Errors
+      Dimensions:
+        - Name: FunctionName
+          Value: !Ref ConvertRequestToFhirFormatFunctionName
+      Period: 60 #seconds
+      EvaluationPeriods: 1
+      Statistic: Sum
+      ComparisonOperator: GreaterThanOrEqualToThreshold
+      Threshold: 1
+      Unit: Count
+      TreatMissingData: notBreaching
+      ActionsEnabled: !Ref EnableAlerts
+      AlarmActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      InsufficientDataActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
+      OKActions:
+        - !ImportValue lambda-resources:SlackAlertsSnsTopicArn
diff --git a/SAMtemplates/main_template.yaml b/SAMtemplates/main_template.yaml
@@ -147,4 +147,7 @@ Resources:
       Parameters:
         StackName: !Ref AWS::StackName
         GetStatusUpdatesFunctionName: !GetAtt Functions.Outputs.GetStatusUpdatesFunctionName
+        UpdatePrescriptionStatusFunctionName: !GetAtt Functions.Outputs.UpdatePrescriptionStatusFunctionName
+        PrescriptionStatusUpdatesTableName: !GetAtt Tables.Outputs.PrescriptionStatusUpdatesTableName
+        ConvertRequestToFhirFormatFunctionName: !GetAtt Functions.Outputs.ConvertRequestToFhirFormatFunctionName
         EnableAlerts: !Ref EnableAlerts
diff --git a/SAMtemplates/state_machines/main.yaml b/SAMtemplates/state_machines/main.yaml
@@ -30,7 +30,7 @@ Parameters:
   EnableSplunk:
     Type: String
 
-  FihrValidatorStackName:
+  FhirValidatorStackName:
     Type: String
     Default: fhir-validator
 
@@ -45,7 +45,7 @@ Resources:
       DefinitionSubstitutions:
         FhirValidationFunctionArn: !Join
           - ":"
-          - - Fn::ImportValue: !Sub ${FihrValidatorStackName}:FHIRValidatorUKCoreLambdaArn
+          - - Fn::ImportValue: !Sub ${FhirValidatorStackName}:FHIRValidatorUKCoreLambdaArn
             - snap
         UpdatePrescriptionStatusFunctionArn: !Sub ${UpdatePrescriptionStatusFunctionArn}:$LATEST
       Logging:
@@ -68,7 +68,7 @@ Resources:
         AdditionalPolicies: !Join
           - ","
           - - Fn::ImportValue: !Sub ${StackName}:functions:${UpdatePrescriptionStatusFunctionName}:ExecuteLambdaPolicyArn
-            - Fn::ImportValue: !Sub ${FihrValidatorStackName}:FHIRValidatorUKCoreExecuteLambdaPolicyArn
+            - Fn::ImportValue: !Sub ${FhirValidatorStackName}:FHIRValidatorUKCoreExecuteLambdaPolicyArn
         LogRetentionInDays: !Ref LogRetentionInDays
         CloudWatchKMSKeyId: !ImportValue account-resources:CloudwatchLogsKmsKeyArn
         EnableSplunk: !Ref EnableSplunk