Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameter prt_params%woody integer #864

Merged
merged 4 commits into from
Jun 3, 2022

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented May 4, 2022

Description:

Parameter prt_params%woody is used to decide whether a PFT is woody or not. Instead of
converting it to integer whenever a logical test is to be performed, I turned the parameter
integer.

Changes associated with this pull request were originally included in #800.

Collaborators:

@rgknox @glemieux

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

mpaiao and others added 2 commits May 3, 2022 13:44
Parameter prt_params%woody is used to decide whether a PFT is woody or not. Instead of
converting it to integer whenever a logical test is to be performed, I turned the parameter
integer.
@glemieux
Copy link
Contributor

glemieux commented Jun 1, 2022

All expected tests pass b4b: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr864

@glemieux
Copy link
Contributor

glemieux commented Jun 3, 2022

Retested post-merge conflict. All expected pass b4b again:
/glade/u/home/glemieux/scratch/ctsm-tests/tests_pr864-deconflict

@glemieux glemieux merged commit d273ede into NGEET:master Jun 3, 2022
@mpaiao mpaiao deleted the mpaiao-pr-woody-int branch December 4, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants