Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bb_slope fix: carea fix: icefilter #76

Merged
merged 3 commits into from
Jun 27, 2016
Merged

fix: bb_slope fix: carea fix: icefilter #76

merged 3 commits into from
Jun 27, 2016

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jun 16, 2016

This PR bundles 3 fixes that address:
#73
#69
#44

The fix to 73 is the only one that would be expected to have b4b regressions. I performed baseline simulation comparsisons between f1a14d6 and 18613d1, and tests confirmed b4b on all expected passes. One extra step was necessary, in that I needed to update the parameter file values of BB_slope to match what was previously hard coded (a value of 9). The current value in the default parameter file is 8, we can certaintly change this going forward. Not changing this now.

The other two fixes, #69 and #44 are not supposed to generate b4b results, and they don't. 1x1 brazil simulations were also run on eddi to make sure that the non-b4b changes continue to generate very similar projections of forest composition and structure, as well as flux variables. They did.

Fixes: #73, #69, #44

User interface changes?: no

Code review: Self

Test suite: lawrencium-lr3 intel, eddi (PC) gnu (visualizations)
Test baseline: 18613d1
Test namelist changes: none
Test answer changes: see above

Test summary:

DONE ERS_D_Ld5.f19_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest : (test finished, successful coupler log) 
     --- Test Functionality  ---:
    FAIL ERS_D_Ld5.f19_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest.clm2.h0.nc : test compare clm2.h0 (.base and .rest files) 
    FAIL ERS_D_Ld5.f19_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest.cpl.hi.nc : test compare cpl.hi (.base and .rest files) 
    FAIL ERS_D_Ld5.f19_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest : test functionality summary (ERS_test) 

DONE ERS_D_Ld5.f09_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest : (test finished, successful coupler log) 
     --- Test Functionality  ---:
    FAIL ERS_D_Ld5.f09_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest.clm2.h0.nc : test compare clm2.h0 (.base and .rest files) 
    FAIL ERS_D_Ld5.f09_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest.cpl.hi.nc : test compare cpl.hi (.base and .rest files) 
    FAIL ERS_D_Ld5.f09_g16.ICLM45ED.lawrencium-lr3_intel.clm-edTest : test functionality summary (ERS_test) 

rgknox added 3 commits June 14, 2016 14:01
…o be used directly instead of mbb, which was a redundant variable. 2) removed redundant conductance and interstitial co2 calculations.
…lm_driv() after the ed driver call, to match that of the expected allocation on the subroutines side
@bandre-ucar
Copy link
Contributor

testing on yellowstone

@bandre-ucar bandre-ucar merged commit ae6112f into NGEET:master Jun 27, 2016
@rgknox rgknox deleted the rgknox-bbfix-careafix-icefiltfix branch August 5, 2016 23:51
@bandre-ucar bandre-ucar removed their assignment Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bb_slope is read from parameter file, but overwritten prior to use
2 participants