-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameter file updates #659
Conversation
Added rooting profile updates, per #290 |
Compared commit after adding in the fire-threshold and dbhmin parameters with commit before it, results are b4b: |
paired with: ESCOMP/CTSM#1027 |
do we want to pull in @rosiealice's PFT matrix term into this?rosiealice@f0170fd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Simplifying the rooting profile scheme makes sense at this point, and glad to get these parameters in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small changes, and a question on if we should suggest the range for fire_threshold
Co-authored-by: jkshuman <[email protected]>
Co-authored-by: jkshuman <[email protected]>
@rgknox so for the tests, I assume you will start by confirming the BallBerry model produces similar results as before and then in the future we would want to test both versions or eventually just the default (Medlyn?) |
@serbinsh yup, exactly. I'm wondering what extra tests, if any, we should perform before switching to Medlyn as the default model in the parameter file. I feel it might be a good idea to run a global simulation with it for a few decades just to see if anything weird happens (like an f10_f10 grid). Since the default parameter set (right now) is more about stress testing the model in different modes, and less about providing scientifically reasonable base set, the bar is low in terms of producing reasonable global benchmarks. Although, arriving at a default parameter set that does the latter is the long-term goal, and adding Medlyn as the default their may help get us to that goal. |
Co-authored-by: jkshuman <[email protected]>
@rgknox Both @Qianyuxuan and I would be happy to talk through a baseline run. We can even do that run here if helpful. But before we do that we should perhaps think about exactly what we need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgknox thanks for your continued work on this. looks good.
Test updates look nominal: I did the cheyenne gnu test suite, which is nice for small syntax updates like these (two tests), and baseline comparisons were b4b. I propose we freeze changes on this PR. In your hands now @glemieux |
Description:
This is a group of changes to the parameter file, not backwards compatible.
Collaborators:
Many, see : #616
Expectation of Answer Changes:
Implementing non-answer changing modificaitons first, will test incrementally
Checklist:
Test Results:
Tested addition of Medlyn stomatal parameters, matches baseline, moving on to next set
/glade/scratch/rgknox/clmed-tests/fates-sci.1.36.0_api.11.1.0-clm5.0.30-v1-Cd525994c-Fed442bb3.fates.cheyenne.gnu