-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nutrient Enabled Aquisition (parteh pt 3) #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arteh-acnp-withlive
…allows us to make them targets.
glemieux
reviewed
Sep 21, 2020
biogeochem/FatesSoilBGCFluxMod.F90
Outdated
! boundary conditions, and parse those fluxes out to the cohorts. | ||
! | ||
! This routine should be called before FATES dynamics, particularly before | ||
! any of the PARTEH code is called. It is assumed that these utpake fluxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on uptake
…/fates into parteh-acnp-withlive-restartfixes
… call to change the demand in non-coupled mode.
…/fates into parteh-acnp-withlive-restartfixes
…/fates into parteh-acnp-withlive-restartfixes
…tside of inner loop. Fixed an un-allocated array that was used in pft-unionized uptake mode
Co-authored-by: Charlie Koven <[email protected]>
…arteh-acnp-withlive
Co-authored-by: Charlie Koven <[email protected]>
Co-authored-by: Charlie Koven <[email protected]>
…arteh-acnp-withlive
…h the FindInactive tool
all expected PASS: /glade/scratch/rgknox/clmed-tests/fates-sci.1.42.0_api.14.0.1-ctsm1.0.dev095-Cf6893b1a-F22508576.fates.cheyenne.gnu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the last set of changes needed to get a fully nutrient enabled version of FATES working (basic hypothesis). This includes new state variables, boundary conditions with the host model, and the code governing the live plant allocation. Output boundary conditions include the demands and/or affinities for N and P depending on the soil competition scheme used in the host model (ECA/RD), and any efflux by the plants is added to the already existing labile flux pools from FATES to host model. Input boundary conditions are the minerarlized nutrient uptake fluxes at either the cohort or PFT scale.
This code currently must be used with the following ELM branch: https://github.com/rgknox/E3SM/tree/rgknox/lnd/fates-nutrient-bcs
Note there is a good amount of python code dedicated to the single-plant simulator, in the functional unit test folder, so the total number of lines changed in FATES is not quite as high as expected at first glance.
Fixes #633
Synchronized with: ESCOMP/CTSM#1148
Collaborators:
Lots of people have helped an contributed to this work, notably: @ckoven and @qzhu-lbl
Expectation of Answer Changes:
Due to changes in order of operations, I do not expect (but would be pleasantly surprised) that answers will stay the same in carbon only mode.
Checklist:
Test Results:
TBD
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: