Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutrient Enabled Aquisition (parteh pt 3) #598

Merged
merged 103 commits into from
Sep 25, 2020

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jan 9, 2020

Description:

This is the last set of changes needed to get a fully nutrient enabled version of FATES working (basic hypothesis). This includes new state variables, boundary conditions with the host model, and the code governing the live plant allocation. Output boundary conditions include the demands and/or affinities for N and P depending on the soil competition scheme used in the host model (ECA/RD), and any efflux by the plants is added to the already existing labile flux pools from FATES to host model. Input boundary conditions are the minerarlized nutrient uptake fluxes at either the cohort or PFT scale.
This code currently must be used with the following ELM branch: https://github.com/rgknox/E3SM/tree/rgknox/lnd/fates-nutrient-bcs

Note there is a good amount of python code dedicated to the single-plant simulator, in the functional unit test folder, so the total number of lines changed in FATES is not quite as high as expected at first glance.

Fixes #633

Synchronized with: ESCOMP/CTSM#1148

Collaborators:

Lots of people have helped an contributed to this work, notably: @ckoven and @qzhu-lbl

Expectation of Answer Changes:

Due to changes in order of operations, I do not expect (but would be pleasantly surprised) that answers will stay the same in carbon only mode.

Checklist:

  • My change requires a change to the documentation. (FATES with CNP hypothesis IS in the technical manual)
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

rgknox and others added 30 commits June 18, 2019 12:39
! boundary conditions, and parse those fluxes out to the cohorts.
!
! This routine should be called before FATES dynamics, particularly before
! any of the PARTEH code is called. It is assumed that these utpake fluxes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on uptake

@rgknox
Copy link
Contributor Author

rgknox commented Sep 24, 2020

all expected PASS:

/glade/scratch/rgknox/clmed-tests/fates-sci.1.42.0_api.14.0.1-ctsm1.0.dev095-Cf6893b1a-F22508576.fates.cheyenne.gnu
/glade/scratch/rgknox/clmed-tests/fates-sci.1.42.0_api.14.0.1-ctsm1.0.dev095-Cf6893b1a-F22508576.fates.cheyenne.intel

@glemieux glemieux merged commit 03a17bf into NGEET:master Sep 25, 2020
@rgknox rgknox deleted the parteh-acnp-withlive branch October 31, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extremely high simulated NEP in sci.1.34.0_api.9.0.0
5 participants