Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-evaluate prescribed nutrient uptake in uncoupled model #698

Closed
rgknox opened this issue Sep 23, 2020 · 1 comment
Closed

re-evaluate prescribed nutrient uptake in uncoupled model #698

rgknox opened this issue Sep 23, 2020 · 1 comment

Comments

@rgknox
Copy link
Contributor

rgknox commented Sep 23, 2020

With the forthcoming PR #598, we allow an uncoupled simulation mode, where we can prescribe nutrient uptake rates, and break the nutrient connection to the soil (if optioned in E3SM, or the exclusive option in CTSM).

Currently, the uptake rates are calculated like so:

  1. assess a cohort's nutrient needs for the current daily time-step by evaluating the total nutrient needed to match NPP and get the plant tissues up to optimal CN and CP ratios in all tissues. We do this by running the allocation scheme an extra time, where we pretend there was an inordinate amount of nutrient available, and document how much was actually allocated.
  2. for the next time-step, we average in the need calculated in step 1 to a smoothed daily demand. demand = a*demand + (a-1)*need
  3. the actual uptake on the next step is calculated as the demand from step 2, multiplied by a user specified parameter: the fraction of the demand desired for uptake. Setting this to >1 will seemingly give the plant plenty of nutrient and prevent nutrient sink limitations to growth

Issues:

  1. See comment by @ckoven here: Nutrient Enabled Aquisition (parteh pt 3) #598 (comment)
  2. The calculation of the need in step 1, is inefficient, it makes us run the allocation solver twice
  3. My sense is that this should have some conceptual basis, whereas right now it is just kind of using some type of circular logic
@rgknox
Copy link
Contributor Author

rgknox commented Mar 9, 2023

Closing, this is referencing old methods of specifying prescribed uptake.

@rgknox rgknox closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant