Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lasslop wind effect on fire ROS #455

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Remove Lasslop wind effect on fire ROS #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90310d7
Merge remote-tracking branch 'ngeet_repo/master'
jkshuman Dec 20, 2018
96a28d6
Remove Lasslop et al 2014 wind effect
jkshuman Dec 20, 2018
3fe14e5
Remove SF_val_wind_max from SFParams
jkshuman Dec 20, 2018
34f580c
remove wind_max from SFMainMod
Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions fire/SFMainMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,8 @@ subroutine rate_of_spread ( currentSite )
use SFParamsMod, only : SF_val_miner_total, &
SF_val_part_dens, &
SF_val_miner_damp, &
SF_val_fuel_energy, &
SF_val_wind_max
SF_val_fuel_energy

use FatesInterfaceMod, only : hlm_current_day, hlm_current_month

type(ed_site_type), intent(in), target :: currentSite
Expand All @@ -426,7 +426,6 @@ subroutine rate_of_spread ( currentSite )
real(r8) beta_ratio ! ratio of beta/beta_op
real(r8) a_beta ! dummy variable for product of a* beta_ratio for react_v_opt equation
real(r8) a,b,c,e ! function of fuel sav
real(r8) wind_elev_fire !wind speed (m/min) at elevevation relevant for fire

logical,parameter :: debug_windspeed = .false. !for debugging

Expand Down Expand Up @@ -493,21 +492,9 @@ subroutine rate_of_spread ( currentSite )

! Equation A5 in Thonicke et al. 2010
! phi_wind (unitless)
! convert wind_elev_fire from m/min to ft/min for Rothermel ROS eqn
! wind max per Lasslop et al 2014 to linearly reduce ROS for high wind speeds
!OLD! phi_wind = c * ((3.281_r8*currentPatch%effect_wspeed)**b)*(beta_ratio**(-e))
if (currentPatch%effect_wspeed .le. SF_val_wind_max) then
wind_elev_fire = currentPatch%effect_wspeed
phi_wind = c * ((3.281_r8*wind_elev_fire)**b)*(beta_ratio**(-e))
if (debug_windspeed) write(fates_log(),*) 'SF wind LESS max ', currentPatch%effect_wspeed
if (debug_windspeed) write(fates_log(),*) 'month and day', hlm_current_month, hlm_current_day
else
!max condition 225 ft/min (FIREMIP Rabin table A10 JSBACH-Spitfire) convert to 68.577 m/min
wind_elev_fire = max(0.0_r8,(68.577_r8-0.5_r8*currentPatch%effect_wspeed))
phi_wind = c * ((3.281_r8*wind_elev_fire)**b)*(beta_ratio**(-e))
if (debug_windspeed) write(fates_log(),*) 'SF wind GREATER max ', currentPatch%effect_wspeed
if (debug_windspeed) write(fates_log(),*) 'month and day', hlm_current_month, hlm_current_day
endif
! convert current_wspeed (wind at elev relevant to fire) from m/min to ft/min for Rothermel ROS eqn
phi_wind = c * ((3.281_r8*currentPatch%effect_wspeed)**b)*(beta_ratio**(-e))


! ---propagating flux----
! Equation A2 in Thonicke et al.2010 and Eq. 42 Rothermal 1972
Expand Down
9 changes: 0 additions & 9 deletions fire/SFParamsMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module SFParamsMod
real(r8),protected :: SF_val_miner_damp
real(r8),protected :: SF_val_max_durat
real(r8),protected :: SF_val_durat_slope
real(r8),protected :: SF_val_wind_max ! Maximum wind speed expected by fire model (m/min)
real(r8),protected :: SF_val_alpha_FMC(NFSC)
real(r8),protected :: SF_val_CWD_frac(NCWD)
real(r8),protected :: SF_val_max_decomp(NFSC)
Expand Down Expand Up @@ -56,7 +55,6 @@ module SFParamsMod
character(len=param_string_length),parameter :: SF_name_low_moisture_Slope = "fates_low_moisture_Slope"
character(len=param_string_length),parameter :: SF_name_mid_moisture_Coeff = "fates_mid_moisture_Coeff"
character(len=param_string_length),parameter :: SF_name_mid_moisture_Slope = "fates_mid_moisture_Slope"
character(len=param_string_length),parameter :: SF_name_wind_max = "fates_fire_wind_max"

public :: SpitFireRegisterParams
public :: SpitFireReceiveParams
Expand Down Expand Up @@ -90,7 +88,6 @@ subroutine SpitFireParamsInit()
SF_val_miner_damp = nan
SF_val_max_durat = nan
SF_val_durat_slope = nan
SF_val_wind_max = nan

SF_val_CWD_frac(:) = nan

Expand Down Expand Up @@ -150,9 +147,6 @@ subroutine SpitFireRegisterScalars(fates_params)

character(len=param_string_length), parameter :: dim_names_scalar(1) = (/dimension_name_scalar/)

call fates_params%RegisterParameter(name=SF_name_wind_max, dimension_shape=dimension_shape_scalar, &
dimension_names=dim_names_scalar)

call fates_params%RegisterParameter(name=SF_name_fdi_a, dimension_shape=dimension_shape_scalar, &
dimension_names=dim_names_scalar)

Expand Down Expand Up @@ -191,9 +185,6 @@ subroutine SpitFireReceiveScalars(fates_params)

class(fates_parameters_type), intent(inout) :: fates_params

call fates_params%RetreiveParameter(name=SF_name_wind_max, &
data=SF_val_wind_max)

call fates_params%RetreiveParameter(name=SF_name_fdi_a, &
data=SF_val_fdi_a)

Expand Down
5 changes: 0 additions & 5 deletions parameter_files/fates_params_14pfts.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,9 +569,6 @@ variables:
float fates_fdi_b ;
fates_fdi_b:units = "NA" ;
fates_fdi_b:long_name = "spitfire parameter (unknown) " ;
float fates_fire_wind_max ;
fates_fire_wind_max:units = "m/min" ;
fates_fire_wind_max:long_name = "maximum wind speed expected by the fire model" ;
float fates_fuel_energy ;
fates_fuel_energy:units = "kJ/kg" ;
fates_fuel_energy:long_name = "pitfire parameter, heat content of fuel" ;
Expand Down Expand Up @@ -1189,8 +1186,6 @@ data:

fates_fdi_b = 243.12 ;

fates_fire_wind_max = 45.718 ;

fates_fuel_energy = 18000 ;

fates_max_durat = 240 ;
Expand Down
5 changes: 0 additions & 5 deletions parameter_files/fates_params_coastal_veg.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,9 +527,6 @@ variables:
float fates_fdi_b ;
fates_fdi_b:units = "NA" ;
fates_fdi_b:long_name = "spitfire parameter (unknown) " ;
float fates_fire_wind_max ;
fates_fire_wind_max:units = "m/min" ;
fates_fire_wind_max:long_name = "maximum wind speed expected by the fire model" ;
float fates_fuel_energy ;
fates_fuel_energy:units = "kJ/kg" ;
fates_fuel_energy:long_name = "pitfire parameter, heat content of fuel" ;
Expand Down Expand Up @@ -947,8 +944,6 @@ data:

fates_fdi_b = 243.12 ;

fates_fire_wind_max = 45.718 ;

fates_fuel_energy = 18000 ;

fates_max_durat = 240 ;
Expand Down
5 changes: 0 additions & 5 deletions parameter_files/fates_params_default.cdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,9 +569,6 @@ variables:
float fates_fdi_b ;
fates_fdi_b:units = "NA" ;
fates_fdi_b:long_name = "spitfire parameter (unknown) " ;
float fates_fire_wind_max ;
fates_fire_wind_max:units = "m/min" ;
fates_fire_wind_max:long_name = "maximum wind speed expected by the fire model" ;
float fates_fuel_energy ;
fates_fuel_energy:units = "kJ/kg" ;
fates_fuel_energy:long_name = "pitfire parameter, heat content of fuel" ;
Expand Down Expand Up @@ -1066,8 +1063,6 @@ data:

fates_fdi_b = 243.12 ;

fates_fire_wind_max = 45.718 ;

fates_fuel_energy = 18000 ;

fates_max_durat = 240 ;
Expand Down