Remove Lasslop wind effect on fire ROS #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to master
Remove the reducing effect of high wind speeds on fire behavior. Also remove the fire_wind_max that triggers this reducing effect. New reserach shows that there is not a reducing link between wind speed and fire behavior, specifically rate of spread. Andela et al 2018 https://doi.org/10.5194/essd-2018-89 User interface changes?: Yes, remove fire_wind_max parameter Code review: JKShuman Test suite: Cheyenne Test baseline: Test namelist changes: none Test answer changes: expect changes, dependant on wind conditions Test summary: tested for compile on Cheyenne
Code review: JKShuman Test suite: Hobart Test summary: 2 year test run
|
Looks good to me. Do you think there should be a comment to the effect that this option exists in the literature but we've chosen to not use it for the reasons you describe? |
|
Thanks for looking this over. I think the information in the PR as to the removal is enough. |
|
running tests |
|
All pass: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reducing effect of high winds based on Lasslop et al 2014
Description:
Within SFMain remove the conditional clause that reduces fire rate of spread for high wind speeds. Within parameter files removed the parameter for fire_wind_max that triggers the conditional.
This showed an improvement in mode simulated fire behavior in past work (Lasslop et al 2014), but current research demonstrates there is not a clear link between high winds and a reducing effect on rate of spread. Andela et al 2018 ESSDD https://doi.org/10.5194/essd-2018-89
This PR acts to remove this Lasslop et al (2014) reducing effect, and revert back to original Thonicke ROS wind effect.
Collaborators:
JKShuman, RKnox
Expectation of Answer Changes:
Fire behavior rate of spread will be higher at high winds within simulation, dependent on previous fire_wind_max parameter and forcing data.
Checklist:
Test Results:
Code compiles and runs on Hobart.