-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes: step error and min/max args #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty straightforward and good to me. thanks @rgknox!
…a_slp parameters, which should be cm2 sapwood, per m2 leaf area.
Added corrections to the comments and meta-data for the "latosa" (leaf-area-to-sapwood-area) parameters, which were incorrectly labeled as "m2/cm2", the inverse of what it is "cm2/m2". |
Nice! |
…inter-cellular co2 concentrations.
@everpassenger , can you review the changes added in the last commit please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes of names from "intra" to "inter" look good to me. Thanks
…o change the ODE truncation error tolerance threshold.
Description:
This PR fixes the types of a 0's and 1's passed to the temperature dependence scaler on frost mortality. We also update in-code documentation on intercellular co2, and leaf-to-sapwood area parameter.
Collaborators:
See #389 and #390
Gordon Bonan, @everpassenger
Expectation of Answer Changes:
This will change answers slightly, but probably not in the regression tests.
Checklist:
Test Results:
FATES-CLM (or) HLM test hash-tag:
FATES-CLM (or) HLM baseline hash-tag:
CTSM: 19f887d FATES: 14aeb4f
FATES baseline hash-tag:
Test Output:
All PASS (compare as well)