Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: step error and min/max args #391

Merged
merged 7 commits into from
Jun 7, 2018
Merged

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented May 30, 2018

Description:

This PR fixes the types of a 0's and 1's passed to the temperature dependence scaler on frost mortality. We also update in-code documentation on intercellular co2, and leaf-to-sapwood area parameter.

Collaborators:

See #389 and #390
Gordon Bonan, @everpassenger

Expectation of Answer Changes:

This will change answers slightly, but probably not in the regression tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation AND wiki accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

FATES-CLM (or) HLM test hash-tag:

FATES-CLM (or) HLM baseline hash-tag:

CTSM: 19f887d FATES: 14aeb4f

FATES baseline hash-tag:

Test Output:

All PASS (compare as well)

@rgknox rgknox changed the title two simple fixes fixes: step error and min/max args May 30, 2018
@rgknox rgknox requested review from jenniferholm and ckoven May 30, 2018 21:36
Copy link
Contributor

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty straightforward and good to me. thanks @rgknox!

…a_slp parameters, which should be cm2 sapwood, per m2 leaf area.
@rgknox
Copy link
Contributor Author

rgknox commented May 31, 2018

Added corrections to the comments and meta-data for the "latosa" (leaf-area-to-sapwood-area) parameters, which were incorrectly labeled as "m2/cm2", the inverse of what it is "cm2/m2".
This was identified by Gordon Bonan.

@rosiealice
Copy link
Contributor

Nice!

@rgknox
Copy link
Contributor Author

rgknox commented May 31, 2018

@everpassenger , can you review the changes added in the last commit please?

Copy link

@everpassenger everpassenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes of names from "intra" to "inter" look good to me. Thanks

@rgknox rgknox merged commit 1ccd6bb into NGEET:master Jun 7, 2018
@rgknox rgknox deleted the rgknox-small-fixes branch July 31, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants