Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be intercellular CO2 instead of intracellular #387

Closed
everpassenger opened this issue May 23, 2018 · 3 comments
Closed

Should be intercellular CO2 instead of intracellular #387

everpassenger opened this issue May 23, 2018 · 3 comments

Comments

@everpassenger
Copy link

co2_intra_c = can_co2_ppress - anet * can_press * &

I would suggest a small change of the parameter name and its description.

Based on the calculation here, boundary layer conductance and stomatal conductance are considered for calculating co2_intra_c , so this co2_intra_c should be called intercelluar CO2 (i.e. between leaf cells) instead of intracellular (defined in Lin835). If it is intracellular, mesophyll conductance will need to be considered.

@rgknox
Copy link
Contributor

rgknox commented May 31, 2018

This sounds reasonable to me @everpassenger .
I could change all instances of "intra" to "inter" and change documentation accordingly.
Did you want to make the changes though?

@everpassenger
Copy link
Author

@rgknox Please go ahead and make the changes. It is very minor and only appear in this module. Thanks.

@rgknox
Copy link
Contributor

rgknox commented Jul 6, 2018

this was addressed via #391

@rgknox rgknox closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants