Carbon starvation termination mortality reporting #1142
Conversation
…alcz-ckoven-cstarv_term_reporting testing C Koven's change to mortality reporting
…on mortality to M3 canopy and understory mortalities, fixed units for FATES_M3_MORTALITY_* history variables
…porting Land use change version 1 The patch-level land use labels are extended from their prior values of only primary or secondary lands to also include pasture, rangeland, and crops. Land use change in FATES is treated as a disturbance rate (in area/time units) from existing patches with a given land use label to new patches with the new land use label. Thus a fourtg distinct type of disturbances is added to the existing treefall, fire, and logging types. The driving data for this run mode is from the Land Use Harmonization 2 state and transition datasets. The workflow tool for processing this input was previously developed with pull request NGEET#1032.
There was a problem hiding this comment.
aside from that long variable name, this PR looks pretty clean, thanks @jennykowalcz
when we test we can see if it exceeds the max, but it might be a good idea to come up with a shorter name if possible
|
Thanks @rgknox! What's the character limit, is it 32? If so I could shorten to FATES_MORT_CSTARV_CONT_CFLUX_PF. If it's 40 the longer name will be okay. |
…porting Two-stream radiation has been added. It can be activated as an alternative to norman radiation by setting fates_rad_mod=2
There was a problem hiding this comment.
This looks good to me. Thanks @jennykowalcz and @ckoven. I only had two minor suggestions for updated comments.
|
Testing on derecho is under way. |
|
Regression testing is complete and is largely b4b, with the exceptions for All other DIFFs are due to expected folder location: |
Description:
This PR moves carbon-starvation-related termination mortality (i.e. live biomass pools are terminally depleted or total cohort biomass is negative) from the "termination mortality" category to the "carbon starvation mortality" category. See issue 1101 / discussion 1100
Collaborators:
@ckoven made the majority of code changes and did debugging; I did some minor edits, debugging, and testing. Discussions with @JessicaNeedham and @mpaiao
Expectation of Answer Changes:
Total mortality is unchanged, but termination mortality may be lower and carbon starvation mortality may be higher, by an equal magnitude. Example:
C-starve termination mortality reporting.pdf
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: