Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coupler history file fails exact restart #88

Closed
bandre-ucar opened this issue Aug 1, 2016 · 4 comments
Closed

coupler history file fails exact restart #88

bandre-ucar opened this issue Aug 1, 2016 · 4 comments

Comments

@bandre-ucar
Copy link
Contributor

bandre-ucar commented Aug 1, 2016

Summary of Issue:

The merge of c0654db into the clm-trunk merge branch introduced a change that causes the coupler history file to not be bit for bit on a single restart test.

    FAIL ERS_D_Ld5.f45_g37.ICLM45ED.yellowstone_gnu.clm-edTest.cpl.hi.nc : test 
compare cpl.hi (.base and .rest files) 
    FAIL ERS_D_Ld5.f45_g37.ICLM45ED.yellowstone_gnu.clm-edTest : test functionality summary (ERS_test)

Failing fields from TestStatus.log

/glade/scratch/andre/ERS_D_Ld5.f45_g37.ICLM45ED.yellowstone_gnu.clm-edTest.07281644-edg/run/ERS_D_Ld5.f45_g37.ICLM45ED.yellowstone_gnu.clm-edTest.07281644-edg.cpl.hi.0001-01-06-00000.nc.rest.cprnc.out had the following fields that are NOT b4b  

   RMS l2x_Sl_anidr                     7.2491E-19            NORMALIZED  9.0283E-19
    RMS l2x_Sl_anidf                     7.2491E-19            NORMALIZED  8.8489E-19
    RMS l2x_Sl_tref                      4.4538E-15            NORMALIZED  1.6760E-17
    RMS l2x_Sl_qref                      5.2556E-18            NORMALIZED  1.0570E-15
    RMS l2x_Sl_t                         8.9077E-15            NORMALIZED  3.3675E-17
    RMS l2x_Sl_fv                        3.1606E-16            NORMALIZED  2.2130E-15
    RMS l2x_Sl_ram1                      2.2047E-13            NORMALIZED  4.5475E-16
    RMS l2x_Sl_u10                       2.4357E-15            NORMALIZED  8.2384E-16
    RMS l2x_Fall_swnet                   2.9692E-15            NORMALIZED  6.9590E-17
    RMS l2x_Fall_taux                    1.0439E-16            NORMALIZED  3.5435E-15
    RMS l2x_Fall_tauy                    1.0439E-16            NORMALIZED  3.5435E-15
    RMS l2x_Fall_lat                     3.6596E-13            NORMALIZED  3.0123E-14
    RMS l2x_Fall_sen                     1.8567E-13            NORMALIZED  1.3053E-14
    RMS l2x_Fall_lwup                    6.0869E-14            NORMALIZED  2.0968E-16
    RMS l2x_Fall_evap                    1.4619E-19            NORMALIZED  3.0530E-14
    RMS l2x_Fall_flxdst1                 7.3133E-25            NORMALIZED  6.5983E-16
    RMS l2x_Fall_flxdst2                 3.9265E-24            NORMALIZED  6.5999E-16
    RMS l2x_Fall_flxdst3                 9.2073E-24            NORMALIZED  6.5999E-16
    RMS l2x_Fall_flxdst4                 8.6713E-24            NORMALIZED  6.5986E-16

Note: This test is part of the 'ed' suite. All tests in the clm_short suite pass for yellowstone intel, gnu, pgi.

Expected behavior and actual behavior:

Prior to this change, all tests in the 'ed' and 'clm_short' test suites were passing, they should continue to pass with these changes.

Steps to reproduce the problem (should include create_newcase or create_test command along with any user_nl or xml changes):

./create_test -testname ERS_D_Ld5.f45_g37.ICLM45ED.yellowstone_gnu.clm-edTest

What is the changeset ID of the code, and the machine you are using:

264dd21, yellowstone, gnu

@bandre-ucar
Copy link
Contributor Author

I poked at this a bit. Since the merged change incorporates three different bug fixes, I think the sanest way to debug the issues is going to be to back them out one at a time to narrow down the problem. For now I'm going to mark this test as an expected fail.

@rgknox
Copy link
Contributor

rgknox commented Aug 1, 2016

Good plan, thanks for looking into this

On Mon, Aug 1, 2016 at 3:54 PM, Ben Andre [email protected] wrote:

I poked at this a bit. Since the merged change incorporates three
different bug fixes, I think the sanest way to debug the issues is going to
be to back them out one at a time to narrow down the problem. For now I'm
going to mark this test as an expected fail.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#88 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFnnjBkQ57zjlGCTQCqPb4dlcd6UdVAkks5qbnkygaJpZM4JaEyG
.

@bandre-ucar
Copy link
Contributor Author

Note: this was reproducible in the original merge, but was an unexpected pass in 203bb6a.

@bandre-ucar
Copy link
Contributor Author

closing, presumed fixed with 203bb6a.

rgknox pushed a commit that referenced this issue Apr 21, 2017
into andre-ed-clm-16x based on clm-r181

Test suite: ed - yellowstone gnu, intel, pgi
            clm-short - yellowstone gnu, intel, pgi

Testing: all clm_short tests pass. One new expected failure in the
'ed' test suite. Coupler history file is no longer bit for bit on
restart, see #88.
rgknox pushed a commit that referenced this issue Apr 21, 2017
andre-ed-clm-16x.

Test suite: ed - yellowstone intel, gnu, pgi
            clm_short - yellowstone intel, gnu, pgi

Test baseline: none, orginial branch was answer changing.

Test status: all tests pass. expected fail in #88, ERS_D
ICLMED yellowstone_gnu unexpectedly passed.
rgknox pushed a commit that referenced this issue May 23, 2017
into andre-ed-clm-16x based on clm-r181

Test suite: ed - yellowstone gnu, intel, pgi
            clm-short - yellowstone gnu, intel, pgi

Testing: all clm_short tests pass. One new expected failure in the
'ed' test suite. Coupler history file is no longer bit for bit on
restart, see #88.
rgknox pushed a commit that referenced this issue May 23, 2017
andre-ed-clm-16x.

Test suite: ed - yellowstone intel, gnu, pgi
            clm_short - yellowstone intel, gnu, pgi

Test baseline: none, orginial branch was answer changing.

Test status: all tests pass. expected fail in #88, ERS_D
ICLMED yellowstone_gnu unexpectedly passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants