-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fates hydro: transpiration error without leaves #618
Comments
@mariuslam I know that you changed a few parameters based on literature (basic allometry). Did you update any of the hydro parameters? It would be useful to know if those are at the default value. I know that Hydro can be quite sensitive, and since it is failing in the first year in the growing season there may be a basic problem with the way the vegetation is parameterized? |
@mariuslam tagging issue #508 "Simple FatesHydro tests fail due to water balance error very quickly" |
I basically decreased SLA top /max and DBH repro/mH in half of my simulations. But whether I changed the parameters or not, the error is the same with a few days lagg |
Hi @mariuslam -- Also check out this pull request. This is where updates were made when transpiration was zero when using Hydro I've run into this issue before, and here is the line in the code that is generating the endrun - fates/biogeophys/FatesPlantHydraulicsMod.F90 Line 2486 in f55eb83
@rgknox -- This seems to be the opposite of the NaN issues, right? I think we decided there can be times when the HLM has a small transpiration flux, but then on the next time step FATES could drop all leaves (deciduous, etc) and have zero conductance. If the flux differences are small, didn't we decide they are allowed to be out of sync? I believe your calculation of transpiration when there is no leaf area is here - fates/biogeophys/FatesPlantHydraulicsMod.F90 Line 2506 in f55eb83
Should this check (starting at line 2506) be moved up earlier? But I might be confused with the transpiration/conductances changes that were made for the NaN issue, and this looks different from the NaN issue....... |
Try set fmode to 2 to decouple the root biomass with leaf, so that you will not get zero roots when leaves off. |
@mariuslam, could you provide the branches and/or git hashes that you are using for both CTSM and FATES? |
Yes, I am using release-clm5.0.30-5-g5220caaa and sci.1.33.0_api.8.1.0. |
So I tried with fates_allom_fmode = 2 , I don't get the leaf transpiration error, but I do get the water balance exceeding a threshold error. If I comment this Endrun, it crashes later due to a cabon balance error (ERROR in EDMainMod.F90 at line 699). |
@mariuslam |
@rgknox, |
I looked at your error logs. This is easy, there is almost no flow happening at that time, and we are being unnecessarily strict on the solver. The absolute values are so small.
In this line, we just need to uncomment that absolute error part of the logic. But lets decrease the allowable absolute error so it matches the max_wb_step_err: The second error, I see that the solver just isnt converging. In this case it is because of NaNs. Need to think more on this, but I feel like I would need more information. I see this is after a restart read... Perhaps that is the actual problem here. |
Ryan,
This hydraulic endrun error is the same one that I was telling you about
yesterday. On line 3200.
Thanks for your help that we need to uncomment that absolute error part of
the logic.
I’ll make that update for my runs, and if it helps I’ll keep you guys
updated if the same (NaN) or new error occurs.
On Fri, Mar 13, 2020 at 12:36 PM Ryan Knox ***@***.***> wrote:
I looked at your error logs. This is easy, there is almost no flow
happening at that time, and we are being unnecessarily strict on the
solver. The absolute values are so small.
Tri-diagonal solve produced solution with
non-negligable error.
Compartment: 4
Error in forward solution: 2.646977960169689E-023
Estimated delta theta: 3.012237654218378E-020
Rel Error: 8.787414088867874E-004
ENDRUN:
ERROR in FatesPlantHydraulicsMod.F90 at line 4293
In this line, we just need to uncomment that absolute error part of the
logic. But lets decrease the allowable absolute error so it matches the
max_wb_step_err:
https://github.com/rgknox/fates/blob/hydro-diagnostics-wmat/biogeophys/FatesPlantHydraulicsMod.F90#L4286
https://github.com/rgknox/fates/blob/hydro-diagnostics-wmat/biogeophys/FatesPlantHydraulicsMod.F90#L3071
The second error, I see that the solver just isnt converging. In this case
it is because of NaNs. Need to think more on this, but I feel like I would
need more information. I see this is after a restart read... Perhaps that
is the actual problem here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#618 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCVHGB674FEOXKC4WBO2PDRHKDMLANCNFSM4LFHTJTA>
.
--
Jennifer Holm
Research Scientist
Climate and Ecosystems Sciences Division
Lawrence Berkeley National Laboratory
510-495-8083
|
Thanks @jenniferholm |
Hi @rgknox , It seems like decreasing the error and uncommenting the code solves both errors. |
Hi @mariuslam, I ran your Merrelva test. I ran mine slightly differently, as I didn't want to have any data dependencies on global driver data. Note below that I tell the datm that we don't have ZBOT (which I assume it will just use some reasonable value), and we are using TDEW instead of RH:
My simulations also run for the whole period, although I didn't need to modify and error tolerances. I will run some diagnostics and see if my results look normalish. |
Here are results from my simulation. @mariuslam is Merrelva a forrest? I didn't output structural diagnostics, so I can't tell exactly from my simulation, but it doesn't seem like it is generating much of a forest. The differences in lear water potentials (LWP) and absorbing root water potentials (AWP) is also very small, which seems indicative of short vegetation with small hydraulic compartment volumes and low storage. The water potentials don't seem to be going too low. Here are the stomatal p50 and vulnerability: fates_hydr_p50_gs = -1.5 ; I'm curious what a run without hydro looks like. |
I should also remember to generate btran values for both the hydro and non-hydro runs to see how they compare. |
Hi @rgknox , I am running your Hydro along a transect of Sierra 4 cz sties with 18 instances. The model crush on the 1D solving after running about 5 year. I have gone through all the land logs, but none of them recorded any errors. I attached the domain and surface data, and my run script. --------------error message ----------------- error code: 3 tree lai: 1.55157121520306 m2/m2 crown a: 6.680418991953484E-006 r3: 7.464386342284710E-003 r4: 9.443384083168961E-002 r5: 1.19470642130446 ERROR: Unknown error submitted to shr_abort_abort.
|
@mariuslam feel free to re-open if you encounter more problems, I believe we made progress on this via: #611 |
Hey @rgknox,
I have been running fates hydro at three sites with two different pft configurations and two different parameter files (12 simulations). Most of them crash with the same "ERROR: transpiration with no leaves" after the first 5, 6, 7 or 8 months. Weirdly one of the 12 simulations showed another ERROR: water balance error.
I attached the log files if you want to have a look. Do not hesitate to ask for more information.
Cheers, Marius
log_files.zip
The text was updated successfully, but these errors were encountered: