Enhance Readme #55
Merged
Enhance Readme #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #54
widhalmt
added
documentation
danopt
requested changes
Dec 15, 2022
|
Thanks, I always wondered if it wouldn't be easier to link to sections instead of just referencing them. But to be honest, I was too lazy to look it up. 😅 TIL: Linking in Markup |
danopt
approved these changes
Dec 15, 2022
tbauriedel
approved these changes
Dec 15, 2022
danopt
added a commit
that referenced
this pull request
Jan 11, 2023
* Support of SAN for etcd * Removed trailing spaces * Update README.md Co-authored-by: Thomas Widhalm <[email protected]> * Update tasks/main.yml Co-authored-by: Thomas Widhalm <[email protected]> * Update tasks/main.yml Co-authored-by: Thomas Widhalm <[email protected]> * Update README.md Co-authored-by: Thomas Widhalm <[email protected]> * Fixed syntax * Check for instance key (#52) * Check for instance key * Use new ca_client_ca_dir * Add check for server certificate fixes #51 * Enhance Readme (#55) * Enhance Readme fixes #54 * Added link to "Contributing" chapter Co-authored-by: DanOPT <[email protected]> * Added tasks to create additional peer and server certificates for etcd * Resolved merge conflict of README.md * Resolved tasks/main.yml * Removed trailing spaces * Updated README.md * Update README.md * Added first part of molecule verification * Finished molecule verification tasks * Get IP addresses of nodes by group name for etcd certificates * Fixed trailing spaces * Fixed groups in molecule.yml * Converted groups to array * Added packages and start Networkmanager for EL in prepare.yml * Added empty line EOF to prepare.yml * Changed volume to rw instead r * Added cgroupns_mode to molecule.yml * Changed actions to v3 * Removed CentOS 7 from molecule tests * Improved default(omit) to default(omit, true) Co-authored-by: Thomas Widhalm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to make more clear what the role is about and how to add more functionality.
fixes #54