-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of additional SAN for etcd #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a few annotations. To be honest, I couldn't test the whle code so there might still be typos in my version. But I hope I could show what I intended.
Co-authored-by: Thomas Widhalm <[email protected]>
Co-authored-by: Thomas Widhalm <[email protected]>
Co-authored-by: Thomas Widhalm <[email protected]>
Co-authored-by: Thomas Widhalm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have a look at my comment? Maybe I misunderstood your change but if I see it correctly it might break any option of using the role for anything else than etcd when the etcd option is set. That's ok but please make it clear in the Readme.
* Check for instance key * Use new ca_client_ca_dir * Add check for server certificate fixes #51
* Enhance Readme fixes #54 * Added link to "Contributing" chapter Co-authored-by: DanOPT <[email protected]>
Changes:
|
Fixes #56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very, very good! Thanks for the great contribution!
Thx. Not a problem at all. ;-) |
Fixes #48
To support etcd the IP addresses and the loopback address has to be defined in the SAN.
To achieve this a temporary variable
ca_san
will be defined with set_fact. I also implemented the support of custom additional SANs with the variableca_san_custom
.This is the value of the variable
ca_san
, after it is defined with set_fact and the whitespaces are removed with regex_replace():`DNS:rockylinux-8-03,DNS:rockylinux-8-03,DNS:vm-3,IP:127.0.0.1,IP:10.0.53.15,IP:10.0.53.15,IP:10.0.53.15'
The string of
ca_san_custom
variable has to begin with a ',' and could look like this to add the IP address of a second NIC (will be combined withca_san
):