Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

PRTL 2501 milestone feedback #2513

Merged
merged 16 commits into from
Apr 24, 2019

Conversation

samrichca
Copy link
Contributor

@samrichca samrichca commented Apr 15, 2019

  • add new cards to the bottom of the order
  • smoothly scroll to newly added card
  • change ‘cause of death’ default card to ‘primary diagnosis’
  • sticky facet headers & panel

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@samrichca samrichca marked this pull request as ready for review April 17, 2019 18:20
@samrichca samrichca requested a review from anncatton April 17, 2019 18:21
@samrichca samrichca closed this Apr 17, 2019
@samrichca samrichca reopened this Apr 17, 2019
@samrichca samrichca changed the title PRTL 2501 milestone feedback [WIP] PRTL 2501 milestone feedback Apr 17, 2019
},
...currentAnalysis.displayVariables,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this moves the new card to the bottom of the order

@samrichca samrichca changed the title [WIP] PRTL 2501 milestone feedback PRTL 2501 milestone feedback Apr 23, 2019
}));
.filter(
bucket =>
!IS_CDAVE_DEV ? bucket.key !== '_missing' : bucket.key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!IS_CDAVE_DEV ? bucket.key !== '_missing' : bucket.key
IS_CDAVE_DEV ? bucket.key : bucket.key !== '_missing'

: makeFilter([
{
.filter(
bucket => (!IS_CDAVE_DEV ? bucket.key !== '_missing' : bucket.key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bucket => (!IS_CDAVE_DEV ? bucket.key !== '_missing' : bucket.key)
bucket => (!IS_CDAVE_DEV ? bucket.key : bucket.key !== '_missing')

@samrichca samrichca merged commit fa4264b into feature/PRTL-2417-cdave-results-layout Apr 24, 2019
@samrichca samrichca deleted the PRTL-2501-feedback branch April 24, 2019 20:07
anncatton added a commit that referenced this pull request Apr 26, 2019
Original branch renamed to `legacy/feature/PRTL-2417-cdave-results-layout

* ✨ PRTL-2415 Add cdave to analysis, restyle

* create clinical analysis selection

* PRTL-2418 update cdave analysis (#2470)

* Edit analysis name, duplicate analysis.

* hide cdave analyses in results when flag is false

* ✨ PRTL-2443 categorical histogram (#2472)

* PRTL-2468 tooltip (#2474)

* PRTL-2469 display missing key values (#2473)

* PRTL-2445 categorical survival (#2479)

* ✨ PRTL-2464 continuous histogram (#2478)

* Investigate sizing issue (#2483)

* PRTL-2483 overall survival (#2482)

* 💄 PRTL-2404 display survival x-axis in years (#2484)

* PRTL-2482 calculate missing from hits (#2485)

* 💄 Put tooltip on fieldname, remove question mark icon (#2488)

* add check for typo fix in index, change no data row names (#2490)

* set order for control panel nodes (#2491)

* change survival plot tooltip from 'days' to 'years' (#2500)

* PRTL-2508 refactor analysis data fetch (#2495)

* ✨PRTL-2451 switch cdave cohort (#2499)

* ✨ PRTL-2451 Switch analysis cohort

* Prtl 2484 categorical curves (#2486)

* Prtl 2494 facet toggles (#2503)

* PRTL-2475 add case set actions to card (#2502)

* PRTL-2517 remove unnecessary layout breaking scrollbars

* Prtl 2452 search (#2506)

* ✨PRTL-2521 export to tsv on clinical analysis (#2515)

*  ✨ PRTL-2514 enable demo clinical analysis (#2514)

* ✨ Disable cohort switch and edit name in demo mode

* [PRTL-2503] Print/download Clinical Analysis plots (#2517)

This reverts commit e1f1a2e.

* PRTL-2435 add eslint autosave config (wip)

* PRTL 2501 milestone feedback (#2513)

* PRTL-2435 add more eslint rules

* PRTL-2435 improve import, brace and parens handling

* Prtl 2533 refresh survival on cohort change (#2520)

* PRTL 2417 fix capitalization of leftIcon (#2524)

This reverts commit ae7e116.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants