This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
✨ Feature - Clinical Analysis #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* restructure variable storage. can update chart and calc type. delete from card. * add new variables at the top * Edit analysis name, duplicate analysis. * feedback fixes * Grid display for cards. Cleanup * fix 508 violations * refactor redux actions * remove fieldname from variable values * Cleanup, typing for variable card * moaarrr typing * fix edit analysis property. Use EditableLabel * cleanup
…ub.com/NCI-GDC/portal-ui into feature/PRTL-2417-cdave-results-layout
* add useful facet count to control panel * include _missing in x count * switch back to missing as no data * wip * restore continuous agg functionality * delete facet count component * cleanup * fix continuous null check. Add deprecated message * redirect to analysis launch if set id is undefined * cleanup * reorganize folders * moaarr cleanup * feedback fixes
* add useful facet count to control panel * include _missing in x count * switch back to missing as no data * wip * restore continuous agg functionality * delete facet count component * cleanup * fix continuous null check. Add deprecated message * redirect to analysis launch if set id is undefined * cleanup * reorganize folders * moaarr cleanup * ✨ PRTL-2451 Switch analysis cohort * Fix dropdown button alignment. Don't change analysis name on cohort switch * Fix dropdown width * Show deprecated result with dropdown
* make overall survival plot full height differentiate survival plots, hide elements in clinical analysis plots line up survival & histogram plots Log multi-survival plot to console survival plot is showing up in cards trying out 5 lines add more colours, fix heading and table issues categorical - 2 default curves continuous - 2 default curves fix s# text click to add more plots working on colours finished colours messages for maximum plots remove unused code * wip * show overall plot when nothing is selecteD * disable buttons with insufficent survival data * wip * wip * stopped survival plots from loading multiple times * continuous survival plot working * categorical survival plot works * refactoring * creating the right data for 2 default continuous survival curves * showing top 2 continuous values * working on button tooltips * working on button tooltips * finished button tooltips for continuous survival * working on continuous survival plot, all curves are showing up * remove sorting in selected continuous survival curves * remove initial load of all curve data * improved performance in survival plots * refactoring * cleanup, make disabled buttons fade out * cleanup, disable _missing values * add count link back to continuous cards * add props change check * revert typescript formatting
* install react toggle * make facet title clickable * add pretty toggles * cleanup * make toggles smaller * remove facet toggle component
* add useful facet count to control panel * include _missing in x count * switch back to missing as no data * wip * restore continuous agg functionality * delete facet count component * cleanup * fix continuous null check. Add deprecated message * redirect to analysis launch if set id is undefined * cleanup * reorganize folders * moaarr cleanup * fix regex for facet query * can create new set from selected buckets * wip continuous save set * modify continuous range filter func * add correct filter for _missing key * wip update analysis set when removing cases * update all analyses when related set removes cases * update related analyses with append set action * merge from feature. set action changes analyses only when type is case
PRTL-2517 remove unnecessary layout breaking scrollbars
* add search field props * remove console log * moved facets code out of the component * add search filter * filter by title or description * add highlight * cleanup * don't match default description * show description if there's a match, hide titles if there's no facet matches * style search results * remove props
* ✨ Add export TSV functionality to variables cards
* sample demo * ✨ Disable cohort switch and edit name in demo mode
* add button type to stop submit action * add print css and print button * move survival plot css to the right folder * add print icon to icon index * adding print css * don't print empty survival plots * Revert "don't print empty survival plots" This reverts commit e1f1a2e. * improve styling * remove background colours * revert TS formatting
add new cards to the bottom of the order smoothly scroll to newly added card change ‘cause of death’ default card to ‘primary diagnosis’ sticky facet headers & panel
* formatting * add a clinical survival plot component * don't attempt to plot low-count values * refactor filtering * plots are refreshing on analysis/cohort change * working, going to test on netlify * debugging 500 error * fix 500 error * move spreads inside conditions * stop adding false/empty objects * revert spreads * update eslint settings * update spread operators * remove unused code
samrichca
reviewed
Apr 25, 2019
| @@ -36,7 +36,7 @@ export default class extends React.Component { | |||
| onClick(); | |||
| createSet(props); | |||
| }} | |||
| leftIcon={leftIcon} | |||
| lefticon={leftIcon} | |||
There was a problem hiding this comment.
all lowercase "lefticon" is incorrect
* eslint fixes * fix lefticon capitalization * trying eslint * Revert "trying eslint" This reverts commit ae7e116.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.