Legend 5: Render continuous palette #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianguerin
approved these changes
Jun 12, 2024
yvonnesjy
force-pushed
the
feature-1784-continuous-palette
branch
2 times, most recently
from
1605327 to
60de683
Compare
robyngit
approved these changes
Jun 17, 2024
| return 1; // Allow 1 decimal places | ||
| } | ||
| return 0; // No decimal places | ||
| }, |
There was a problem hiding this comment.
👍🏻 Good idea moving this to Utilities
yvonnesjy
force-pushed
the
feature-1784-continuous-palette
branch
from
60de683 to
a955bec
Compare
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
... following BEM principle: minimize nested selectors.
Co-authored-by: Robyn <[email protected]>
Co-authored-by: Robyn <[email protected]>
yvonnesjy
force-pushed
the
feature-1784-continuous-palette
branch
from
26dad45 to
199ee9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.