Legend 2: Create legend components #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianguerin
approved these changes
Jun 11, 2024
robyngit
requested changes
Jun 17, 2024
| new AssetColorPalette( | ||
| _.extend( | ||
| assetConfig.colorPalette, | ||
| _.pick(assetConfig, "label"), |
There was a problem hiding this comment.
If I understand, here we pass on the layer's label to overwrite the name of the property that is displayed in the legend. Why are we doing this? We may want to display the name of the property that is actually shown in the legend, or use the label that is configured in the colorPalette config.
There was a problem hiding this comment.
Ah yea I saw that palette's label is currently not used so I assumed it's safe to override. But I just noticed that it's mentioned in ColorPaletteConfig so other portals might have it configured. I updated it to use the layer label only if a label is not set in the color palette config.
yvonnesjy
force-pushed
the
feature-1784-create-legend-components
branch
from
95f4e04 to
901e4b5
Compare
robyngit
reviewed
Jun 17, 2024
robyngit
reviewed
Jun 17, 2024
Co-authored-by: Robyn <[email protected]>
Co-authored-by: Robyn <[email protected]>
These scoped type names are used inconsistently throughout the code base and violate lint rules. I will not attempt a fix in this PR, and hold off until we have an agreed upon approach.
yvonnesjy
force-pushed
the
feature-1784-create-legend-components
branch
from
2c14302 to
43bdf9f
Compare
robyngit
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.