dtc/hwrf-physics: HWRF RRTMG (based on #30) #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst three hours, not just the first one
This was referenced Apr 8, 2020
|
Attached is a screenshot of the 2m temperature differences after three hours of integration using the tests This is by no means a full evaluation of the newly added code, just a poor man's attempt to show that the implementation of HWRF RRTMG produces reasonably looking results.
|
|
Regression testing on hera.intel against the original/official EMC baseline located in rt_full_against_existing_baseline.log |
Description of final regression testingBased on the results above (#36 (comment)), a new baseline is generated and the location of the regression test baseline ( The contents of Individual stepsCreating new HWRF physics baseline in Syncing Adding a subdirectory Verifying against new HWRF physics baseline using |
…est namelist templates and run scripts, use own HWRF regression test baseline
|
All completed, PR is ready to merge! |
ligiabernardet
approved these changes
Apr 8, 2020
Ok, thank you. I will wait for approval from one of the CODEOWNERs to start the merge process. Once this is in, I will look at the Noah LSM PRs from Grant. |
mzhangw
approved these changes
Apr 9, 2020
grantfirl
reviewed
Apr 9, 2020
| @@ -129,6 +129,9 @@ | |||
| pre_rad = .false. | |||
| ncld = 5 | |||
| imp_physics = 15 | |||
There was a problem hiding this comment.
I've been doing the same thing as @mzhangw, editing this namelist for my HWRF physics schemes. Should we consider changing the name since it will be valid for many (all?) HWRF schemes (and not just the FA scheme)?
There was a problem hiding this comment.
we can consolidate all HWRF namelist options once all schemes are ready.
There was a problem hiding this comment.
@grantfirl if you like, please do that as part of the Noah LSM PR (when you pull in the updates from these PRs before the final testing). Thanks!
grantfirl
approved these changes
Apr 9, 2020
Closed
panll
pushed a commit
to panll/ufs-weather-model
that referenced
this pull request
Apr 21, 2020
* Updated fv3atm (see fv3atm PR NCAR#48 NOAA-EMC/fv3atm#48) * Updated WW3
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ufs-weather-model
that referenced
this pull request
Sep 24, 2020
Add tracer sanitizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #30 by @mzhangw, but for branch dtc/hwrf-physics instead of dtc/develop. It also contains several bug fixes and updates to the original PR.
The following commits were cherry-picked from #30 (all from @mzhangw):
5ab446f
1cbc515
c6f51f5
2a43ab1
73f5dcb
The additional commits apply changes necessary for switching the target branch (e.g., add the new regression tests to the correct
rt.shconfiguration filert.conf). In addition, several files that were added as part of the original PR #30 for testing purposes only are removed.Associated PRs:
NCAR/ccpp-physics#430
NCAR/fv3atm#38
#36
For regression testing information, see below (in progress).