forked from NOAA-EMC/fv3atm
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dtc/hwrf-physics: HWRF RRTMG (based on #33) #38
Merged
climbfuji
merged 9 commits into
NCAR:dtc/hwrf-physics
from
climbfuji:dtc_hwrf-physics_add_rrtmg
Apr 9, 2020
Merged
dtc/hwrf-physics: HWRF RRTMG (based on #33) #38
climbfuji
merged 9 commits into
NCAR:dtc/hwrf-physics
from
climbfuji:dtc_hwrf-physics_add_rrtmg
Apr 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stitial%clouds, update CCPP suite definition files
…loud effective radii (for testing purposes only)
This was referenced Apr 8, 2020
grantfirl
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Closed
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Sep 24, 2020
…_emc_20200625 Update gsd/develop from develop 2020/06/25 and mods to MYNN sfc and PBL for fractional/coupled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #33 by @mzhangw, but for branch dtc/hwrf-physics instead of dtc/develop. It also contains several bug fixes and updates to the original PR.
The following commits were cherry-picked from #33 (all from @mzhangw):
1bae50c
ed8347e
f1cad88
d9841c8
3c64b5a
The additional commits apply bug fixes (use correct vertical dimension for the Interstitial%clouds array) from @mzhangw that were made on the ccpp-physics side, but not on the fv3atm side (
GFS_typedefs.meta
). In addition, several code changes/files that were added as part of the original PR #33 for testing purposes only are reverted/removed.Associated PRs:
NCAR/ccpp-physics#430
#38
NCAR/ufs-weather-model#36
For regression testing information, see NCAR/ufs-weather-model#36