Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/hwrf-physics: HWRF RRTMG (based on #33) #38

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 8, 2020

This PR is based on #33 by @mzhangw, but for branch dtc/hwrf-physics instead of dtc/develop. It also contains several bug fixes and updates to the original PR.

The following commits were cherry-picked from #33 (all from @mzhangw):
1bae50c
ed8347e
f1cad88
d9841c8
3c64b5a

The additional commits apply bug fixes (use correct vertical dimension for the Interstitial%clouds array) from @mzhangw that were made on the ccpp-physics side, but not on the fv3atm side (GFS_typedefs.meta). In addition, several code changes/files that were added as part of the original PR #33 for testing purposes only are reverted/removed.

Associated PRs:
NCAR/ccpp-physics#430
#38
NCAR/ufs-weather-model#36

For regression testing information, see NCAR/ufs-weather-model#36

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@climbfuji climbfuji merged commit fd70a2c into NCAR:dtc/hwrf-physics Apr 9, 2020
@climbfuji climbfuji mentioned this pull request Apr 9, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Sep 24, 2020
…_emc_20200625

Update gsd/develop from develop 2020/06/25 and mods to MYNN sfc and PBL for fractional/coupled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants