Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 Support #599

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Drop Python 3.9 Support #599

merged 2 commits into from
Apr 22, 2024

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Apr 22, 2024

PR Summary

Closes #553

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck self-assigned this Apr 22, 2024
@cyschneck cyschneck added the deprecation A feature is being deprecated or removed label Apr 22, 2024
@cyschneck
Copy link
Contributor Author

The current PR checks are expecting the three remaining tests for Python 3.9 across platforms, but they are no longer being generating, so those three unfinished tests can be ignored

@cyschneck cyschneck marked this pull request as ready for review April 22, 2024 21:27
@cyschneck cyschneck requested a review from anissa111 April 22, 2024 21:27
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I'll go turn off the required checks for 3.9 now.

@anissa111 anissa111 merged commit 9150633 into NCAR:main Apr 22, 2024
12 checks passed
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the minor release notes item!

I am curious if we have any pending or planned work that's not 3.9 compatible.

If not, I might have a slight preference for holding off a little bit on this (at least until the end of the iteration). It looks like xarray hasn't dropped 3.9 quite yet and our examples gallery can't move to 3.12 yet because of wrf-python.

@@ -11,8 +11,10 @@ Upcoming release

Internal Changes
^^^^^^^^^^^^^^^^
* Drop Python 3.9 Support by `Cora Schneck`_ in (:pr:`599`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want this in a different category. Maybe "Compatibility Notes" or "Breaking Changes"? @anissa111, I've been meaning to ask - is there a list of categories you use for release notes?

anissa111 pushed a commit to anissa111/geocat-comp that referenced this pull request Apr 22, 2024
* remove 3.9 support and  workflows

* update release-notes.rst
anissa111 added a commit to anissa111/geocat-comp that referenced this pull request Apr 22, 2024
@cyschneck cyschneck deleted the remove_python39_553 branch April 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation A feature is being deprecated or removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.9 Support
3 participants