Scientific Doc of UGWP Version 0 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bluefinweiwei
commented
Nov 1, 2019
•
bluefinweiwei
commented
- This is the official PR with the content approved by Valery.
- Add UGWPv0 to "all schemes" list
- wrote stub for UGWPv0 "landing page"
- landing page points to existing UGWPv0 documentation and main paper
- Doxygen configuration file edited to find UGWPv0 source code and landing page
- library.bib updated with UGWPv0 references
- added Doxygen markup to put all UGWPv0-related subroutines in UGWPv0 doxygen group
- added brief not for subroutines gwdps_v0
bluefinweiwei
requested review from
climbfuji,
ligiabernardet,
grantfirl and
mzhangw
bluefinweiwei
requested review from
JulieSchramm and
llpcarson
as code owners
bluefinweiwei
force-pushed
the
ugwp_doc
branch
4 times, most recently
from
6b22dc9 to
f751683
Compare
bluefinweiwei
changed the title
|
Valery has proofread the content and given his approval. I would consider this as the final PR. |
bluefinweiwei
force-pushed
the
ugwp_doc
branch
from
f751683 to
88d8f7f
Compare
modified: cires_ugwp_triggers.F90 modified: docs/ccpp_doxyfile modified: docs/library.bib new file: docs/pdftxt/UGWPv0.txt modified: docs/pdftxt/all_shemes_list.txt modified: ugwp_driver_v0.F
bluefinweiwei
force-pushed
the
ugwp_doc
branch
from
88d8f7f to
12b644a
Compare
climbfuji
approved these changes
Nov 14, 2019
|
Once we get approval from either Julie, Man or Ligia, I will merge this PR. |
|
@ligiabernardet @JulieSchramm @mzhangw please have a look at this PR and approve if ok so that it doesn't get stale ... thanks! |
|
Working on it. Tks for the nudge
…On Mon, Nov 25, 2019 at 9:32 AM Dom Heinzeller ***@***.***> wrote:
@ligiabernardet <https://github.com/ligiabernardet> @JulieSchramm
<https://github.com/JulieSchramm> @mzhangw <https://github.com/mzhangw>
please have a look at this PR and approve if ok so that it doesn't get
stale ... thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#347?email_source=notifications&email_token=AE7WQAUBB5VI5R7LAOMDOTLQVP4X7A5CNFSM4JHXWINKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFC7WLI#issuecomment-558234413>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAUSOJEPQH42EBCFRWLQVP4X7ANCNFSM4JHXWINA>
.
|
|
I would like to pull this into #366 and merge it into dtc/develop as it is now. Please let me know if that's ok. |
|
This PR has been pulled into #366 |
|
Please do not merge this PR as it will be merged automatically with #366. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.