Modify interval determination approach #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor out interval calculation method - Reduce interval factor to generate more intervals per shape - See #18
ghost
added
the
pdavidc
approved these changes
Jan 9, 2018
pdavidc
pushed a commit
that referenced
this pull request
Feb 2, 2018
- Refactor out interval calculation method - Reduce interval factor to generate more intervals per shape - See #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.
Description of the Change
Refactored out the interval determination calculation, providing an entry point for apps to customize the result while still attempting to dynamically provide an interval value with suitable visual appearance. Reduced the original interval factor to increase the number of points for a given shape geometry.
Applicable Issues
#18