Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipse / SurfaceEllipse #18

Closed
pdavidc opened this issue Aug 30, 2016 · 4 comments
Closed

Ellipse / SurfaceEllipse #18

pdavidc opened this issue Aug 30, 2016 · 4 comments
Assignees
Milestone

Comments

@pdavidc
Copy link
Contributor

pdavidc commented Aug 30, 2016

Display of an ellipse in 3D and an ellipse draped on the terrain surface. From the COE requirements document:

Circle

  • Ability to display a circle features
  • Coordinate (lat,lon,altitude)
  • Radius
  • Line Thickness, Line Color, Dashed lines , Dotted line, Line Alpha, Fill Color, Fill Alpha, Text Label
  • Altitude mode

Ellipse

  • Point with major radius, minor radius, and rotation
  • Coordinate (lat,lon,altitude)
  • Major radius
  • Minor radius
  • Rotation in degrees
  • Line Thickness, Line Color, Dashed lines , Dotted line, Line Alpha, Fill Color, Fill Alpha, Text Label
  • Altitude mode
@pdavidc pdavidc added this to the WWA v0.8.0 milestone Dec 15, 2017
zglueck added a commit that referenced this issue Jan 4, 2018
- Only implemented as a surface shape
- See #18
@ghost ghost assigned zglueck Jan 4, 2018
pdavidc pushed a commit that referenced this issue Jan 6, 2018
* Add initial ellipse shape
- Only implemented as a surface shape
- See #18

* Add documentation and clean up properties

* Fix getter code format

* Add temporary fix for interval determination

* Add handling of major and minor axis inversion

* Add dynamic interval determination based on ellipse size
@pdavidc
Copy link
Contributor Author

pdavidc commented Jan 6, 2018

We've established an initial ellipse shape and corresponding tutorial within the WorldWindAndroid source code. We'll create an easier to use tutorial on worldwind.arc.nasa.gov soon. In the meantime, the in-code tutorial can be found in on GitHub:
https://github.com/NASAWorldWind/WorldWindAndroid/blob/develop/worldwind-tutorials/src/main/java/gov/nasa/worldwindx/EllipseFragment.java

@JACochran the initial Ellipse is ready for integration into the EMP repository. We're working on adjustments that increase the ellipse's level of detail, which will be available prior to your next release.

zglueck added a commit that referenced this issue Jan 8, 2018
pdavidc pushed a commit that referenced this issue Jan 8, 2018
zglueck added a commit that referenced this issue Jan 8, 2018
- Refactor out interval calculation method
- Reduce interval factor to generate more intervals per shape
- See #18
pdavidc pushed a commit that referenced this issue Jan 9, 2018
- Refactor out interval calculation method
- Reduce interval factor to generate more intervals per shape
- See #18
@zglueck
Copy link
Contributor

zglueck commented Jan 9, 2018

@JACochran, we've updated the Ellipse implementation in pr #201. If possible, we suggest it be integrated into the EMP release.

@pdavidc
Copy link
Contributor Author

pdavidc commented Jan 12, 2018

@rsupnekar @JACochran @jrummel, we've implemented enhancements to WorldWindAndroid's Ellipse shape:
• Dynamic level of detail #204
• Enhanced geometric precision for small ellipses #205

Please try these in EMP and let us know how it works there. We're working on a final enhancement: reducing the memory used by WorldWindAndroid's Ellipse #207. We'll let you know when that's ready to try in EMP.

zglueck added a commit that referenced this issue Jan 19, 2018
# Conflicts:
#	worldwind/src/main/java/gov/nasa/worldwind/shape/Ellipse.java
@zglueck
Copy link
Contributor

zglueck commented Feb 1, 2018

All COE requirements are satisfied with the exception of integrated label; however, WWA provides labels as a separate capability.

@zglueck zglueck closed this as completed Feb 1, 2018
@ghost ghost removed the in progress label Feb 1, 2018
pdavidc pushed a commit that referenced this issue Feb 2, 2018
* Add initial ellipse shape
- Only implemented as a surface shape
- See #18

* Add documentation and clean up properties

* Fix getter code format

* Add temporary fix for interval determination

* Add handling of major and minor axis inversion

* Add dynamic interval determination based on ellipse size
pdavidc pushed a commit that referenced this issue Feb 2, 2018
pdavidc pushed a commit that referenced this issue Feb 2, 2018
- Refactor out interval calculation method
- Reduce interval factor to generate more intervals per shape
- See #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants