Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can't use "SNAPSHOT" in Python packaging #66

Closed
nutjob4life opened this issue Sep 22, 2021 · 2 comments · Fixed by #68
Closed

We can't use "SNAPSHOT" in Python packaging #66

nutjob4life opened this issue Sep 22, 2021 · 2 comments · Fixed by #68
Assignees
@MJJoyce
Labels
bug Something isn't working
Milestone
14.Carl.Lewis

Comments

@nutjob4life
Copy link
Member

🐛 Describe the bug

Argh, I thought this was familiar! Too much to keep track of! Despite all the effort we put into #62 we can't use SNAPSHOT in Python packaging; see https://github.com/NASA-PDS/pds-doi-service/runs/3670410132?check_suite_focus=true#step:6:1040 for an example.

See https://www.python.org/dev/peps/pep-0440/#public-version-identifiers … we can have dev, but no snapshot.
@nutjob4life nutjob4life added bug Something isn't working needs:triage labels Sep 22, 2021
@MJJoyce
Copy link
Contributor

MJJoyce commented Sep 22, 2021

Darth_Vader_Noooo_Banner

@MJJoyce MJJoyce mentioned this issue Sep 22, 2021
Closed
@MJJoyce
Copy link
Contributor

MJJoyce commented Sep 22, 2021

Note, in addition the updates in NASA-PDS/pds-github-util#44 we need to revert the naming changes from #61 and #63

@MJJoyce MJJoyce added this to the 14.Carl.Lewis milestone Sep 22, 2021
MJJoyce added a commit that referenced this issue Sep 22, 2021
@MJJoyce
Revert Python snapshot naming for PEP 440 compliance
c50b390 
Revert the `dev` to `SHAPSHOT` changes in #61 and #63. Using `SNAPSHOT`
in the version string is not PEP 440 compliant and results in rejection
of releases when pushing them to PyPI. This requires the changes in
NASA-PDS/pds-github-util#44.

Resolve #66
@MJJoyce MJJoyce mentioned this issue Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
bug Something isn't working
Projects
None yet
Milestone
14.Carl.Lewis
Development

Successfully merging a pull request may close this issue.

Revert Python snapshot naming for PEP 440 compliance NASA-PDS/roundup-action
3 participants
@nutjob4life @MJJoyce @tloubrieu-jpl