Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Revert Python SNAPSHOT release naming changes #44

Closed
MJJoyce opened this issue Sep 22, 2021 · 0 comments · Fixed by #45
Closed

Revert Python SNAPSHOT release naming changes #44

MJJoyce opened this issue Sep 22, 2021 · 0 comments · Fixed by #45
Assignees
@MJJoyce
Labels
bug Something isn't working
Milestone
14.Carl.Lewis

Comments

@MJJoyce
Copy link
Contributor

MJJoyce commented Sep 22, 2021 •
edited
Loading

Per @nutjob4life in NASA-PDS/roundup-action#66, the dev -> SNAPSHOT naming changes made in #37 aren't valid! PEP 440 won't allow SNAPSHOT in the version string. It'll parse as a legacy version string and get rejected.

>>> packaging.version.parse('0.3.1-dev-20210922035133')
<Version('0.3.1.dev20210922035133')>
>>> packaging.version.parse('0.3.1-SNAPSHOT-20210922035133')
<LegacyVersion('0.3.1-SNAPSHOT-20210922035133')>

We need to change the SNAPSHOT version string back to dev.
@MJJoyce MJJoyce mentioned this issue Sep 22, 2021
Closed
MJJoyce added a commit that referenced this issue Sep 22, 2021
@MJJoyce
Revert Python snapshot release naming for PEP 440 validity
25dc5c4 
Change Python snapshot release naming from using `-SNAPSHOT` as a
post-fix to `-dev` so we're generating valid PEP 440 version strings.

Resolve #44
@MJJoyce MJJoyce mentioned this issue Sep 22, 2021
Merged
@MJJoyce MJJoyce self-assigned this Sep 22, 2021
@MJJoyce MJJoyce added this to the 14.Carl.Lewis milestone Sep 22, 2021
@MJJoyce MJJoyce added bug Something isn't working sprint-backlog labels Sep 22, 2021
MJJoyce added a commit to NASA-PDS/roundup-action that referenced this issue Sep 22, 2021
@MJJoyce
Revert Python snapshot naming for PEP 440 compliance
c50b390 
Revert the `dev` to `SHAPSHOT` changes in #61 and #63. Using `SNAPSHOT`
in the version string is not PEP 440 compliant and results in rejection
of releases when pushing them to PyPI. This requires the changes in
NASA-PDS/pds-github-util#44.

Resolve #66
@MJJoyce MJJoyce mentioned this issue Sep 22, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MJJoyce MJJoyce

Labels
bug Something isn't working
Projects
None yet
Milestone
14.Carl.Lewis
Development

Successfully merging a pull request may close this issue.

Revert Python snapshot release naming for PEP 440 validity NASA-PDS/pds-github-util
2 participants
@MJJoyce @tloubrieu-jpl