Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open all external links in a new tab #870
Open all external links in a new tab #870
Changes from all commits
a6c3ab8
59980bf
e0744b2
9f7fcc6
d58f347
8997c35
6dbcc5b
1c8c31d
677e5b6
c1cb6c5
58c89ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work? I tested in the deploy preview and looks like the external link I clicked wasn't opening in a new tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandrahoang686 that's because we also need externalLinksInNewTab set to true on veda-config/veda.config.js.
It is working on veda-config-ghg (US-GHG-Center/veda-config-ghg#326) and also on my local machine.
I had to set it this way to prevent typescript error which was expecting "to" prop from the function