Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to open external links in a new tab #326

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Conversation

sandesh-sp
Copy link
Collaborator

@sandesh-sp sandesh-sp commented Mar 18, 2024

Add config to open external links in a new browser tab

Closes #315

@sandesh-sp sandesh-sp requested a review from slesaad March 18, 2024 21:02
@sandesh-sp sandesh-sp self-assigned this Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit 9718800
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/662a3c7b08a8b8000804d383
😎 Deploy Preview https://deploy-preview-326--ghg-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j08lue
Copy link
Collaborator

j08lue commented Mar 19, 2024

Which commit or version are you updating VEDA UI to, @sandesh-sp, and why?

I see the change in VEDA UI to use this setting has not been merged yet.

@sandesh-sp
Copy link
Collaborator Author

@j08lue I might be unaware of the process. Should the changes on veda-ui be merged before I send a pull request here?

@j08lue
Copy link
Collaborator

j08lue commented Mar 19, 2024

Should the changes on veda-ui be merged before I send a pull request here?

Yes, we have not been requiring versioned releases on VEDA UI for instances to use, lately, but it should at least be merged to main on VEDA UI and ideally also version-tagged.

Btw, once we have turned VEDA UI into a library, hopefully later this year, you will have to use a packaged release.

@j08lue
Copy link
Collaborator

j08lue commented Apr 2, 2024

To avoid the merge conflicts for VEDA UI upgrade, perhaps make this PR just about the content changes and merge it only when VEDA UI has been updated (elsewhere).

@slesaad
Copy link
Collaborator

slesaad commented Apr 3, 2024

@j08lue that's the plan. for now, we just wanted to test the feature with this PR. We'll wait for the next veda-ui release to merge this PR.

@slesaad slesaad marked this pull request as draft April 3, 2024 14:17
@j08lue
Copy link
Collaborator

j08lue commented Apr 3, 2024

Ah, sorry I broke it then. Back to main for now.

@j08lue j08lue marked this pull request as ready for review April 25, 2024 11:19
@j08lue
Copy link
Collaborator

j08lue commented Apr 25, 2024

How to test this:

See that the link to the IPCC-related website in the intro story

See that links in the footer still work as expected.

@j08lue j08lue requested review from sandrahoang686 and removed request for slesaad April 25, 2024 13:35
@j08lue j08lue merged commit 9b1cbb0 into develop Apr 25, 2024
5 checks passed
@j08lue j08lue deleted the external-link-config branch April 25, 2024 18:18
@slesaad slesaad mentioned this pull request May 6, 2024
1 task
dzole0311 pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All external links should open in a new tab
4 participants