Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag not to show the colormap #1147

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Sep 5, 2024

Related Ticket: #1142

Description of Changes

Turn off colormap configurability. It is default to off, but instances can turn it on by setting up environment variable SHOW_CONFIGURABLE_COLOR_MAP

While working on it, I noticed a black end of the gradient color bar, so I included the fix here, too.

Screenshot 2024-09-05 at 4 50 11 PM

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 759c4a0
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66da1f2c41f5c50008ed2f41
😎 Deploy Preview https://deploy-preview-1147--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested enabling/disabling the flag, works as expected.

Thanks for fixing the black border as well! 🙏

@hanbyul-here hanbyul-here merged commit 3f92a79 into main Sep 6, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the 1142-turn-off-colormap branch September 6, 2024 13:51
sandrahoang686 added a commit that referenced this pull request Sep 25, 2024
## 🎉 Features
- [E&A] Implement colormap configurability
#1117
- [E&A] Feature flag colormap configurability
#1147
- Add font md size as 20px for new Design System
#1125
## 🚀 Improvements
- [E&A] Return default value of colormap along with other settings
#1128
- Create new raster paint layer module and factor out
BaseTimeseriesProps #1105
- Consolidate a place where to check linkProps
#1121
#1160
- Expose Data Catalog and update child components to pass in routing/nav
for library build #1096
#1159
- Set up eslint rule for no trailing spaces
#1146
- Replace cmr-stac with titiler-cmr
#1131
## 🐛 Fixes
- Update external link in top navigation target
#1145
- Update PageHeader/Nav to not throw
#1149
- [E&A] Fix to convert the time to usertzdate
#1151
- Use sourceparams as it is when it is there
#1148
- Fix compare label on block map
#1153
- Discard the previous sourceExclusive value to fix the case when the
datasets with different sourceExclusive can be selected together
#1161
- Show the name of the selected filter on story hub
#1161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants