Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font md size as 20px #1125

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add font md size as 20px #1125

merged 1 commit into from
Aug 27, 2024

Conversation

hanbyul-here
Copy link
Collaborator

Related Ticket: {link related ticket here}

Description of Changes

I often find designs with a font size 20px, this one makes the -md utilities class to be 20px (https://designsystem.digital.gov/design-tokens/typesetting/font/ )
@faustoperez - let's go through the font sizes we need and set the values accordingly soon!

@hanbyul-here hanbyul-here changed the title Add md size as 20px Add font md size as 20px Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 8c94b7b
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66ccd4e7835f4c00086c9b1b
😎 Deploy Preview https://deploy-preview-1125--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here merged commit ebfa3ac into main Aug 27, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the theme-config branch August 27, 2024 12:49
@faustoperez
Copy link

faustoperez commented Aug 29, 2024

This is the VEDA theme typescale I was exploring using USWDS tokens.

We definitely need 10px and 12px for the interface elements and I think we'll need a bit more flexibility for body text and I had thought 18px would meet our needs (USWDS default is 17px for md).

Shall I change md to 20px? 🤔

VEDA type scale

Figma here 👉 https://www.figma.com/design/5mclPTReHcRIzKbJm8YA6a/VEDA---USWDS?node-id=151-177&t=WpvU9mrA9dZkEyDz-1

@hanbyul-here
Copy link
Collaborator Author

@faustoperez, it is surprising to hear that 20px is not on the list, since I found it from the recent design ex. Carousel Title (https://www.figma.com/design/9INQauBWhiRxvOWDGhRrxO/US-GHG-Center?node-id=1523-5340&node-type=FRAME&t=85jgloJkLCO5QBAA-0). We can def map the font sizes again, but then what should current 20px be mapped to? md or lg?

@faustoperez
Copy link

then what should current 20px be mapped to? md or lg?

lg please

@hanbyul-here
Copy link
Collaborator Author

@faustoperez - I just want to flag that our current stories and dataset overview paragraph (<p>) is using 20px as a default font size, (ex. https://veda-ui.netlify.app/stories/life-of-water) which might not be ideal to be converted to lg

sandrahoang686 added a commit that referenced this pull request Sep 25, 2024
## 🎉 Features
- [E&A] Implement colormap configurability
#1117
- [E&A] Feature flag colormap configurability
#1147
- Add font md size as 20px for new Design System
#1125
## 🚀 Improvements
- [E&A] Return default value of colormap along with other settings
#1128
- Create new raster paint layer module and factor out
BaseTimeseriesProps #1105
- Consolidate a place where to check linkProps
#1121
#1160
- Expose Data Catalog and update child components to pass in routing/nav
for library build #1096
#1159
- Set up eslint rule for no trailing spaces
#1146
- Replace cmr-stac with titiler-cmr
#1131
## 🐛 Fixes
- Update external link in top navigation target
#1145
- Update PageHeader/Nav to not throw
#1149
- [E&A] Fix to convert the time to usertzdate
#1151
- Use sourceparams as it is when it is there
#1148
- Fix compare label on block map
#1153
- Discard the previous sourceExclusive value to fix the case when the
datasets with different sourceExclusive can be selected together
#1161
- Show the name of the selected filter on story hub
#1161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants